|
![]() |
|
Thread Tools | Search this Thread | Display Modes |
![]() |
#121 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Here is the trace of what appears after I attempt to play the song; this is all that appears in the console:
code: No playback; just hangs at 00:00. |
![]() |
![]() |
#122 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#123 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
3528 = 236 + 3292 is not what we expect from an AUDCLNT_E_BUFFER_TOO_LARGE error. On the other hand I would expect uFramesPadding / uFramesWrite to be about 50% / 50%.
|
![]() |
![]() |
#124 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#125 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Changed it to Verbose and caught an infinite loop of this:
code: It does this endlessly until I stop playback. EDIT: Tried a song that does work and the above still appears endlessly in the console window while the song plays. |
![]() |
![]() |
#126 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
PHP Code:
http://out-yasapi.sourceforge.net/up...debug-0.9.3.7zEdit: It would be nice if you could do this little experiment but all symptoms point to a remarkable drift between the audio and the timer used to trigger the re-filling of the buffer as the real reason for the strange behavior. Using large buffers to work around this are just curing the symptom not the root cause because large buffers just shift the point where audio and timer are hopelessly out of sync a bit further into the future. |
|
![]() |
![]() |
#127 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
But for today unfortunately I have to say good bye ... |
|
![]() |
![]() |
#128 | |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Quote:
![]() EDIT: Not sure if this helps but as an experiment, I rolled back to v0.82 and the playback problems were gone. They seem specific to v0.9 or later. |
|
![]() |
![]() |
#129 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#130 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Could you please use the above referenced debug version
http://out-yasapi.sourceforge.net/up...debug-0.9.3.7zand produce a trace from the end of that particular song? For that reason you can probably jump (seek) to the end of the song. |
![]() |
![]() |
#131 | |
Junior Member
Join Date: Jul 2010
Posts: 14
|
Quote:
PHP Code:
|
|
![]() |
![]() |
#132 | |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Quote:
Here is what I get at the end of the song: code: |
|
![]() |
![]() |
#133 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
PHP Code:
PHP Code:
Appears a "audio client started" at the beginning as usual? PHP Code:
|
![]() |
![]() |
#134 | |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Checked again and this time I could not see them at all.
Quote:
I do see audio client started. Here is another log where I played something very briefly and stopped. PHP Code:
Last edited by djnforce9; 24th November 2015 at 14:51. |
|
![]() |
![]() |
#135 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
This scenario I cannot test myself because I don't have a device supporting it. It's interesting to see it working with the new release! The last time we had the following error reported by "chros":
PHP Code:
|
![]() |
![]() |
#136 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#137 |
Member
Join Date: Nov 2003
Posts: 77
|
Thanks Peter for the new versions!
bugs (I don't have logs this time, I didn't have time to do them): 1. with the default buffer settings I don't have any playback at all in any output combination (E-push, E-pull, S-pull, S-push): the player just hangs (though there's no force close this time at all) 2. If I modify the buffers to (from top to bottom): 2.0 , 1.5 , 1.0 , then only E-push mode is working not the rest 3 (player hangs, like in point 1.). (so probably it's a buffer problem) 3. UI bugs (cosmetics): - when you hit the default button on the middle tab, the settings on the buffer tab won't change (it happened after using the new version) |
![]() |
![]() |
#138 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
|
![]() |
![]() |
#139 |
Junior Member
Join Date: Feb 2003
Posts: 21
|
v0.9.1 works for me
I am using default buffers, Push, device period default, share mode automatic and auto convert pcm. It sounds very nice. Thanks for the great work.
|
![]() |
![]() |
#140 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Wonder if this may help. My DAC has an LED display that shows me the current sampling rate. If I played a song at 48Khz followed by one that stalls and is a different sampling rate the previous track, my DAC still shows 48Khz until I do the trick where I seek in order to get it playing in which case the sampling rate on the display changes. The stalling is not from sampling rate changes alone though as it does not happen with every file; just something I noticed.
Hopefully it helps narrow things down a bit. EDIT: Another issue I found is files that are 32Khz will not play at all (I get unsupported format even in "Automatic" mode); older versions would switch to "shared" first to play those files. |
![]() |
![]() |
#141 |
Member
Join Date: Oct 2011
Location: Melbourne Australia
Posts: 84
|
Pretty sure I am the first one using the version 0.10. Downloaded it less than 30m since it has been uploaded to Sourceforge. It is working flawlessly and I love the implementation of the graphical progress bars for the buffers. @pbelkner Nice work!
![]() |
![]() |
![]() |
#142 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
v0.10.0
What's new?
![]() EDIT: Please try the new default settings! Links:
Quote:
![]() |
|
![]() |
![]() |
#143 | |||
Senior Member
Join Date: Jun 2010
Posts: 405
|
Please provide a trace with your bug report
Quote:
PHP Code:
Quote:
Quote:
PHP Code:
|
|||
![]() |
![]() |
#144 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#145 |
Junior Member
Join Date: Jul 2010
Posts: 14
|
All my issues with the previous version have been totally rectified by the current version, and Winamp sounds fantastic. Great job Peter!
Edit: While listening to a song I did get a "AUDCLNT_E_BUFFER_TOO_LARGE" error, but once again increasing all the buffers to the right hand side fixed this. Do buffer settings affect sound quality at all, or only the time needed to read/start/stop songs? Edit 2: Looks like I spoke too soon. Only plays FLAC files, does not play MP3. |
![]() |
![]() |
#146 | ||
Senior Member
Join Date: Jun 2010
Posts: 405
|
Please provide a trace for each of the bugs you observe:
http://sourceforge.net/projects/out-....0.7z/downloadIt is close to impossible to resolve a bug by "pure thinking" when you cannot re-produce it. Quote:
Quote:
Again, please provide traces, one for AUDCLNT_E_BUFFER_TOO_LARGE and one for stalling. |
||
![]() |
![]() |
#147 |
Junior Member
Join Date: Jul 2010
Posts: 14
|
I restarted Winamp, reset to default, and now once more it seems to be fine!
I will hold on to that trace debug file though in case it plays up again, and will post here if it does. Thank you so much for your continued assistance on this plugin, much appreciated ![]() |
![]() |
![]() |
#148 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
|
![]() |
![]() |
#149 | |
Junior Member
Join Date: Jul 2010
Posts: 14
|
Quote:
I have a question though - you have stated that adjusting the buffer sizes does NOT affect sound quality whatsoever and only the latency. My question is if we're dealing with milliseconds - what difference does latency really matter? Why should we reduce the latency when you essentially won't notice the difference in real time and would basically need a computer program to measure this exact difference? Or is it going to be noticeable after all? Thanks ![]() |
|
![]() |
![]() |
#150 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
Each audio interface (DirectSound, ASIO ...) introduces some latency due to buffers. It's in their very nature because they need to decouple input from output via buffers. Latency is the time the audio needs to "flow" through the buffers and it's good style to reduce the buffer size to a minimum (ideally to zero) just enough to "buffer away" fluctuations from writing the input and reading the output. A buffer should e.g avoid a situation where the output needs to read and there's no input available. In such a situation you would here pops and glitches. If there where no fluctuations we would hardly need any buffers at all. |
|
![]() |
![]() |
#151 |
Junior Member
Join Date: Jul 2010
Posts: 14
|
Interesting, thank you
![]() |
![]() |
![]() |
#152 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Thanks for the new version.
Certain songs still hang for me regardless of my settings such as this one (balance buffers does not resolve it): https://www.dropbox.com/s/njkr9g3e3u...%20Me.mp3?dl=0 here is the trace when that happens: PHP Code:
EDIT: It seems many of my MP3 files have this same issue and when I play chip tunes such as .nsf files (uses Notso Fatso's NSF plugin), Winamp freezes after I stop playback or change songs; this never happened with the previous version of your plugin. Last edited by djnforce9; 30th November 2015 at 16:05. |
![]() |
![]() |
#153 |
Senior Member
Join Date: Jun 2010
Posts: 405
|
On my site there's no such problem. The final step in filling the buffer is from 3768 to 4655 frames. After this step there are more frames in the buffer then the threshold of 4608 (4032 in your case) and the audio client starts as expected:
PHP Code:
The only thing I can propose for now is to have a another, deeper look into what's going on. Before writing the next batch Winamp issues a "canwrite" request which should return the available/free space in bytes. The only thing I can imagine is that Winamp comes to the conclusion that there's not enough space because of such a "canwrite" call and from then on forever issues "canwrite" calls. In order to test this I have introduced further trace information into a new debug version which you can download from here. In "verbose 2" level the new debug version traces what YASAPI replys to "canwrite": PHP Code:
|
![]() |
![]() |
#154 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
PHP Code:
PHP Code:
|
|
![]() |
![]() |
#155 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
Edit: I strongly suggest to increase the size of the ring buffer. Before v0.9 the default setting was was 4.0 times the shared buffer now it is just 1.5 times. Last edited by pbelkner; 30th November 2015 at 18:46. |
|
![]() |
![]() |
#156 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Increasing the ring buffer resolves the issue where playback would not start on certain MP3's so thanks for that. To clarify, when I said "regardless of my settings", I meant under "Device Options".
However, the crash upon stopping playback for other plugins still persists even with the larger ring buffer size; here is a trace from when I first opened Winamp to when I pressed stop and Winamp froze: PHP Code:
EDIT: This does not happen with all input plugins. So far just playing NSF files through the NotSo Fatso plugin and the latest version of Yasapi crashes Winamp. |
![]() |
![]() |
#157 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
From where do I get this plugin? From where do I get such files? |
|
![]() |
![]() |
#158 | |
Senior Member
Join Date: Jun 2010
Posts: 405
|
Quote:
In order to test it I've compiled a version with the old (wrong) module id 65 you can download here. Could you please give it a try? |
|
![]() |
![]() |
#159 |
Member
Join Date: Nov 2003
Posts: 77
|
Just tried out 0.10 in Shared+Push mode yesterday with the default settings: it's working fine!
![]() I still need the Default Audio device in the device list. (I use ClockAmp to wake up my laptop in the morning, and a wget command line for switching on my avreceiver. The problem is: whenever I start winamp when my TV is on (sometimes in the night, for the next morning), there's only the TV as audio device appears in the list, but in the morning there's not TV but avreceiver, so winamp can't use the only selected TV audio device -> no sound -> maybe I'll be late from work ![]() Thanks |
![]() |
![]() |
#160 |
Junior Member
Join Date: Feb 2014
Posts: 40
|
Did another trace with the NSF file using the debug version you attached. Winamp locks up before it sends the "close" command (although thankfully the debug window does not freeze along with Winamp).
Here is another case where I play an NSF for a while and then hit stop. PHP Code:
http://slickproductions.org/notsofatso.php And you can grab an NSF file here: http://www.zophar.net/music/nsf.html Thank you so much for the effort in resolving this; much appreciated ![]() EDIT: All songs play with a ring buffer of 1.64 or more; any less and certain songs will stall. |
![]() |
![]() |
|
Thread Tools | Search this Thread |
Display Modes | |
|
|