Old 20th March 2007, 21:21   #1
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
unnamed start menu folder?

I have question. Maybe you can help.

My installer stores the selected start menu folder after leaving the start menu page.

Why is the user allowed to choose an unnamed start menu group by deleting the default folder name? The installer start menu page accepts the choice.

I'm thinking of uninstalling and using the /r switch with RMDIR to remove the start menu folder.

(If you did so, the uninstaller would wipe the whole start menu.)

Can you force the user to input a name? If the field is blank, prompt to select a folder?

(For the sake of the argument.)

Thank you.
bnicer is offline   Reply With Quote
Old 20th March 2007, 21:44   #2
kichik
M.I.A.
[NSIS Dev, Mod]
 
kichik's Avatar
 
Join Date: Oct 2001
Location: Israel
Posts: 11,343
Thanks, fixed.

NSIS FAQ | NSIS Home Page | Donate $
"I hear and I forget. I see and I remember. I do and I understand." -- Confucius
kichik is offline   Reply With Quote
Old 21st March 2007, 08:49   #3
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
I don't know, knowing too little to disagree.

I had a narrow escape when I accidentally removed the start menu. I had an up-to-date backup. Those who used installers I made before yesterday might have been less fortunate. ... My apologies anyway, in case you were one of them and are reading this. Sorry.
bnicer is offline   Reply With Quote
Old 21st March 2007, 09:25   #4
Red Wine
Forum King
 
Red Wine's Avatar
 
Join Date: Mar 2006
Location: Ath. GR
Posts: 2,078
For my opinion it was an option not a bug, I might want to place shortcuts in the root of my SM folder along with Windows Media Player, IE, etc.

It is developer's concern the correct and safe usage of RmDir /r, when you use it you should be sure what is going to remove.
Same issue could happen if (surely by accident) someone would remove the folder name in directory page and the installation goes to the root of Program Files (I've seen that some times).
I prefer to leave back an empty folder rather than to remove a system folder.
But if you insist to use the /r switch, then check...
For instance read from registry the selected SM folder and compare this value with $SMPROGRAMS...

Quick AVI Creator - Quick and easy convert from DVD/MPEG/AVI/MKV to AVI/MP4/MKV
Quick AVI Creator entirely edited with NSIS and entirely upgraded to Unicode NSIS
Red Wine is offline   Reply With Quote
Old 21st March 2007, 10:42   #5
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
Yes, that's solid advice, Red Wine. Thanks. I have taken out the /r switch, but your idea is equally doable. I'd be surprised if someone did -- or eventually will, because the installer is still out there -- wipe their start menu 'by accident'. On the other hand, for it to happen once would not be okay anymore. We all learn from our mistakes. Sometimes the hard way, and sometimes at the expense of others. Can't be helped.
bnicer is offline   Reply With Quote
Old 21st March 2007, 14:35   #6
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
I do however appreciate all the effort you put in to help out, if that was ever in question. The installer installed a free add-on for a p2p client that speaking of mistakes, I will not make the mistake of naming, though I will mention by name, the RIAA.

- Tom
bnicer is offline   Reply With Quote
Old 22nd March 2007, 04:47   #7
Anders
Moderator
 
Anders's Avatar
 
Join Date: Jun 2002
Location: ${NSISDIR}
Posts: 5,548
Not all p2p/filesharing is "illegal", no harm in dropping names

IntOp $PostCount $PostCount + 1
Anders is offline   Reply With Quote
Old 22nd March 2007, 16:13   #8
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
Okay. eDonkey2000. The final release of eDonkey2000 (1.45) was booby-trapped to uninstall itself. The company behind the software was called MetaMachine. MM, when threatened with a lawsuit, threw in the towel in 2005 officially. Then, for some reason, the support and distributing of the client didn't stop until August last year. There was an article on a filesharing forum claiming the developers agreed to pay the RIAA $30,000,000. I suspect the report itself might have been planted to scare people off filesharing. $30 million!? That's irresponsible. If you have a working version of eDonkey2000, please don't download anything illegal with it.
bnicer is offline   Reply With Quote
Old 22nd March 2007, 20:24   #9
bnicer
Senior Member
 
Join Date: Feb 2005
Location: London
Posts: 218
I want to edit that last part, but it's too late. It would be even better to avoid eDonkey2000 altogether. There are other "legal" clients. Emule, for instance.
bnicer is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump