BUG: winamp CRASHES when "search the web..." button is pushed

[MrSinatra]

win7 sp1
5.601 Bento

1. open winamp
2. in the "file info window" directly to the right of the top left player controls, (i.e., the top, center window) there are four smallish buttons in the bottom right of said window. the second one is called "Search the web for this artist" and looks like a little magnifying glass.
3. press that button
4. winamp will crash, everytime, pretty quickly

pretty nasty bug. it seems to be trying to open a web browser and the link has the artist data in it but i can't copy b4 it crashes.

can anyone confirm?

[MrSinatra]

Egg, anyone, 35 views and no comment?

can anyone else confirm? it'll take SECONDS to do so...

[DJ Egg]

Can't repro it here.
Got IE9 beta installed, maybe?
If yes, then there's some compatibility fixes coming for the next release.
If no, then... list of plugins & hjt log required...

ps. btw, I'd forgotten all about those buttons. I disabled them a long time ago (via: Options > Appearance menu)

[MrSinatra]

i have win7 sp1 with ie8

the problem seems to be with winamp going to its own browser tab.

just now, it did work with a nick drake song called pink moon, which i didn't expect it would, but other than that, it seems to crash every time.

i have a SS to upload but for some reason your site won't allow it, even tho its within specs.

[Koopa]

Winamp's notifier and the whole Bento browser stuff are crashing for me since the dawn of time.

I get a crash each time, when I make a left click at the notifier and Winamp tries to open a website in the Bento Browser to show artist related infos.

Additionally, I also saw random crashes when clicking at the info buttons in Bento. Bentos browser never worked to well here, so yeah, I guess I can repro your issue.

[MrSinatra]

I STILL CAN'T UPLOAD A PIC. get on the ball winamp!!!

Originally Posted by Koopa

Winamp's notifier and the whole Bento browser stuff are crashing for me since the dawn of time.

I get a crash each time, when I make a left click at the notifier and Winamp tries to open a website in the Bento Browser to show artist related infos.

when i click the "notifier" which i think is the bubble that pops up near the systray as new songs happen, it does work for me, but it goes to the "now playing" thing in the ML tree, not the browser tab. now playing has been stable for me, even when clicked in the top center pane of the file info pane. the " i " button.

the browser will start and run mosly stable if direct clicking on the tab, but if i go to like a flash site or something like that it can crash. i rarely use the winamp browser.

the beef here is in using the second magnifying glass button to take current artist info into the winamp browser. almost every time i get a crash.

Originally Posted by Koopa

Additionally, I also saw random crashes when clicking at the info buttons in Bento. Bentos browser never worked to well here, so yeah, I guess I can repro your issue.

which ones do you mean? the magnifying glass button? others?

[Koopa]

Originally Posted by MrSinatra

when i click the "notifier" which i think is the bubble that pops up near the systray as new songs happen, it does work for me, but it goes to the "now playing" thing in the ML tree, not the browser tab. now playing has been stable for me, even when clicked in the top center pane of the file info pane. the " i " button.

Yup, but ml_nowplaying isn't installed on my system, so it opens the default Webbrowser when I use Winamp Modern Skin and it uses Bento's browser, while using Bento.

I get a crash with both skins.

which ones do you mean? the magnifying glass button? others?

[PaulitaPeetl]

Nice op, i was wondering the same thing myself.

[MrSinatra]

Originally Posted by Koopa

Yup, but ml_nowplaying isn't installed on my system, so it opens the default Webbrowser when I use Winamp Modern Skin and it uses Bento's browser, while using Bento.

I get a crash with both skins.

interesting. so i'd posit that the call to go to a browser is why both your buttons crash yours, since you don't have NP installed. also, i thought it was winamps internal browser causing the crash, but it seems its something in just the call to go to a browser thats responsible, given your "modern" skin results.

ok Egg, we got several confirmations here, can you guys take a look at it?

[Koopa]

I've asked the devs related to the crash bug last year already, if i can remember the main problem is, that it crashes, before you can catch the crash. So it's very hard to track the issue down. But don't quote me on this, best would be, if a winamp dev could reply and gives some feedback.

[Koopa]

I've added the bug to the internal bug tracker, but no idea, when/if they are able to fix it.

[osmosis]

Not seeing the crash with IE9 RC, Windows 7 SP1.

[MrSinatra]

Originally Posted by osmosis

Not seeing the crash with IE9 RC, Windows 7 SP1.

modern skin i assume? try with Bento. (i get it crashed 95% of the time but it is intermittent/hidden for some it seems)

[osmosis]

Nope. With Big Bento it works on my end.. not sure what the trick is. : /

[MrSinatra]

Koopa, i wonder if "the affected" have similar 3rd party plugins?

[Koopa]

Will post a list of my plugins when I come home.

It seems, that one part of my crash issue could be reproduced by the devs and was fixed in the internal builds. The Bento/Modern notifier doesn't crash anymore, if ml_nowplaying isn't present on the system. But I had no time yet to confirm the fix or to see, if the fix is related to the other crash as well.

[MrSinatra]

Koopa,

here's my plugin list from nunz 5.1 done within winamp. i couldn't get the standalone to work (yet) altho i guess this is preferred anyway.

see any similarities to your list? any red flags in mine?

[Koopa]

Sorry for the huge delay, my time frame was evil this week and I forgot about the thread today.

So I'm using the following 3rd party plugins from your list:

Alpha-II SPC Player v3.3.4 (Wrapper v0.9.1) [in_snes.dll]
VGM input plugin v0.36 beta Mar 5 2008 21:07:24 [in_vgm.dll]
Jump To File Extra v1.2.3 (Build 1151) [gen_jumpex.dll]
One for Nunz v5.1 [gen_nunzio.dll]
ML Exporter v0.8.2 [ml_exporter.dll]

I can still post a complete list if you want.

[MrSinatra]

np on the delay.

i wonder if any of those could cause the issue? to test this, would i just temporarily move the file out of the plugin folder and restart winamp and try it? what do you suggest?

[DJ Egg]

We've fixed a bug for the next release where clicking on the Notifier would crash the browser if ml_nowplaying.dll isn't present and the Bento/Modern skin option to 'Open Now Playing on click' is checkmarked (which it is by default). Not sure if it's related to this though, because I could repro the aforementioned problem (in Winamp Modern skin) but not this one.

Yes, close Winamp, go to the %ProgramFiles%\Winamp\Plugins folder.
Create a new Backup subfolder in there and move all non-default/3rd-party plugins into it.
Reopen Winamp, see if the problem persists.
If it doesn't, then you could restore each 3rd-party plugin, one at a time, opening & closing Winamp inbetween, until the problem resurfaces. You'll then know which 3rd-party plugin was to blame.

[MrSinatra]

ok... so i installed 5.61 and the bug still existed. crashed.

so i took out the 5 plugins that Koopa and i share, and no crash!

i followed eggs instructions and the culprit is:

in_snes.dll !!!!!

i can not explain why that plugin would cause the crash, or why invoking the web browser tab via the mag glass button for a normal audio file (which shouldn't involve that plugin AT ALL), would crash it, but the fact is, it does!

it kind of disturbs me to think a totally unrelated plugin would affect a file format and the app it should have nothing to do anything with. but at least the mystery is solved. i just worry about unrelated crap affecting the SQ of otherwise unrelated playback.

so now, how do we fix this bug? was this the plugin DrO updated?

[DJ Egg]

Ahh, in_snes strikes again.
The snesamp people used to update the plugin quite regularly, once upon a time
but looks like the last official update was 3 years ago > http://alpha-ii.com/Download/Main.html#SNESamp

Re: DrO's version
I'll leave that for DrO to respond to (alas, I don't personally even use the plugin/format, so don't really know much about it or the status of the plugin).

[DrO]

am am able to get some sort of crash now i've upgraded my Win7 install to use wrapper v0.9.1 (initial testing was done with v0.9 which didn't seem to cause any issue).

nothing shows up of use in the debugger at the point of crash (though looks like an issue it had with the rar dll during the 0.9 development phase).

why it's triggered with the wrapper present i'm not sure at the moment as nothing off-hand jumps to mind (can't check source code to confirm any suspicions). oh well, adding to the todo list.

-daz

[MrSinatra]

DrO, many thanks. as you know, i break stuff. i have to say, as a user / non-dev, i am totally at a loss in understanding how this dll even involves itself in this action. i like to think of plugins as much more compartmentalized, but i guess that pre-conceived notion is incorrect.

[DrO]

not as much as koopa breaks things

usually things are compartmentalised to an extent but if something goes wonky, it's not like how recent versions of say FF or IE deal with plug-ins/components in contained processes, etc and so can lead to crashing. as for what's going on, anything is possible since i know the handling of the rar dll can be funky in some edge cases but why it crashes on that one action with the wrapper+plug-in doesn't make sense (unless something in the hooking the wrapper has to do inorder to fix the original snesamp plug-in is touching something it shouldn't).

either way, will see when i get a chance to look into the issue.

-daz