Old 30th October 2008, 05:25   #1
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,650
Send a message via AIM to MrSinatra
Trailing spaces... not a bug?

hi egg and all great winamp devs...

in a different thread that had some posts deleted:

http://forums.winamp.com/showthread....94#post2432294

dj egg said that trailing spaces on some tracks album names that results in winamp showing TWO albums is "expected behavior."

in gods name, why? why respect trailing spaces? (or initial ones for that matter)

if some tracks album fields say by the beatles have:

"Help"
and others have
"Help "

why should winamp consider that as two separate albums? especially if they are in the same folder?

and does trailing spaces cause the same issue in the TPE1 and TPE2 fields?

i just don't understand the winamp reasoning for respecting a trailing space. i think it shouldn't. thoughts?

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline   Reply With Quote
Old 30th October 2008, 05:51   #2
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,846
It's only 'expected behaviour' because it's an unimplemented feature to strip trailing spaces. I agree that we should strip trailing spaces, but we don't currently.
Therefore it's a feature request, not a bug :-)
DJ Egg is offline   Reply With Quote
Old 30th October 2008, 05:57   #3
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,650
Send a message via AIM to MrSinatra
but that doesn't really answer my question...

my question is why are they respected? i think they should be ignored by default, not respected and not stripped.

(essentially treated as if they were the way the article "the" is currently)

also, are you saying that the stripping feature is currently in the works for a future release?

finally, does it affect other fields besides the album field?

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline   Reply With Quote
Old 30th October 2008, 06:28   #4
Sawg
Forum King
 
Join Date: Jun 2000
Location: Phoenix, AZ
Posts: 7,456
Send a message via ICQ to Sawg Send a message via AIM to Sawg Send a message via Yahoo to Sawg
Because "Bob" and "Bob " are not the same string. And without actively trimming whitespace at the end then comparing "Bob" and "Bob " will come out as not the same, as they aren't.

| Brought to you by ^V ^C | The one... the original... no seriously!
Sawg is offline   Reply With Quote
Old 30th October 2008, 06:32   #5
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,650
Send a message via AIM to MrSinatra
i don't know what whitespace is, but if the article "the" can be ignored successfully, as well as the space after it in most cases, then why can't a trailing space also be ignored?

eg.

if "the beatles" is seen as "beatles" by winamp, then whats being ignored is not just the article "the" but the space as well, ie. "the "

i know i'm not as smart as you guys, but i don't see what i'm missing?

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline   Reply With Quote
Old 30th October 2008, 06:57   #6
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,846
Because the nde database system has been programmed to treat "The Beatles" and "Beatles" as the same artist, but it hasn't been programmed to treat "Beatles" and "Beatles " as the same artist, because it's not been programmed to ignore trailing spaces (or whitespace, as Sawg calls it).

We refer to it as an unimplemented feature.
You could also call it "undesired behaviour".
But it is currently the expected behaviour, and therefore not a bug.

And yes, it affects ALL metadata fields.

I don't know if it's on the To-Do list, or whether it will ever be implemented. Though I do agree with you that it should be.
DJ Egg is offline   Reply With Quote
Old 30th October 2008, 07:16   #7
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,650
Send a message via AIM to MrSinatra
i understand egg, thx for sticking with me thru these questions...

egg, i thought you were a dev? is that not the case? i thought you and your team decided what was on the to do list, and what got attention, no?

i assumed this b/c this is your forum.

if you don't have the authority to get it on the list to be done, and if its not a bug, then who and where do i make the appeal / request to?

surely something so basic should have a rather high priority, no?

thx for agreeing with me. i appreciate being heard very much.

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline   Reply With Quote
Old 30th October 2008, 08:16   #8
DJ Egg
Techorator
Winamp & Shoutcast Team
 
Join Date: Jun 2000
Posts: 35,846
Yeah, I'm part of the Winamp Team...

Ben Allison (Benski) is the main Winamp dev.
Maksim and DrO are the others. And that's all, really....

I mainly do QA (Quality Assurance), Documentation updates (Whatsnew, History, FAQ, Help, translations, About dialogs, typo fixes, etc), Bug Reports, Forum maintenance (all those lovely stickys and FAQ's etc), Pro Tech Support, Beta builds, and whatever else.

Posting here is all that it takes to get the attention of those who need to know :-)

I can't guarantee if/when this feature request will be implemented, but I've added it to the internal To-Do list. Alas, it's not marked as top priority, as yet.... heh.
DJ Egg is offline   Reply With Quote
Old 20th September 2011, 09:48   #9
MrSinatra
Forum King
 
MrSinatra's Avatar
 
Join Date: Dec 2004
Location: WKPS, State College
Posts: 5,650
Send a message via AIM to MrSinatra
hey Egg and devs...

Quote:
Originally Posted by MrSinatra View Post
my question is why are they respected? i think they should be ignored by default, not respected and not stripped.

(essentially treated as if they were the way the article "the" is currently)
i just thought i'd mention this again, (last was 2008). leading/trailing spaces do seem to be an issue, on android as well.

i wouldn't strip them, since the editor needs to be able to edit them out of the tags... i would simply treat them as the article:

code:
"the" and/or "the "
...is treated, ie. not respected.

do you follow what i mean? i think it would save you some headaches to do something about this, esp where droid is concerned.

wanted to mention this now, since i sense that 5.63 might not be too far off...

PENN STATE Radio or http://www.LION-Radio.org/
--
BUG #1 = Winamp skips short tracks
Wish #1 = Multiple Column Sorting
Wish #2 = Add TCMP/Compilation editing
MrSinatra is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Bug Reports

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump