Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Reply
Thread Tools Search this Thread Display Modes
Old 17th June 2005, 09:00   #121
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
Originally posted by YtseJam
Is it already known tha the colour setup for queued items isn't being saved?
it should be saving in #6 since all that code is hooked up to do so

-daz
DrO is offline   Reply With Quote
Old 17th June 2005, 09:27   #122
DrO
 
Join Date: Sep 2003
Posts: 27,873
i'm running out the door to work (may be late now...) but here's a fixed build for the updater and the defaults crash....

http://www.nunzioweb.com/daz/files/j...(Build_6a).exe

i'll post the changelog here later on

-daz
DrO is offline   Reply With Quote
Old 17th June 2005, 13:59   #123
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 6a is out:: release info

[temp changelog until i get home and can upload to the site]
  • Added in ability for the jtf list to match the current playlist order (configurable option)
  • Added in partial handling of system dpi settings other that 96dpi (so at least the majority of the window/buttons show now)
  • Fixed the DEP crash issue on XP sp2 machines (problem was the language file loader)
  • Fixed a crash bug on the shell options page due to an incorrectly initialised buffer in the registry reading code
  • Improvements to the Colouriser api so it will now use the default skin colours and correctly displays the current item text colour now if it's in the queue
  • Fixed an issue where skin changes / refreshes wouldn't correctly update the colouriser prefs displayed colours if the defaults are in use
  • Added in saving of the queue marking colour options between Winamp instances
  • Checked over the updater code and corrected a comparison bug which could cause invalid new version warnings (reported by arv a long time back! and removed the test settings causing the bug reports for the original build #6)
  • Removed the plugins msvcrt.dll dependancy without increasing the plugins size (cos i wanted to and can )
  • Added a 'Crop to queue' mode from the right click playlist menu
  • Optimised the reading/saving of the playlist right-click menu code to make it easier in future to add in other possible options
  • Added the ability for the 'Scroll to Item' mode to flash highlight the item (either using the current selection background colour or the inverted state of it)
  • Adjusted the Winshade button placement to one pixel to the left after re-assessing the code and from the test images TazDevil provided
  • Added in foreign character handling in the jtf search (base implementation part derived from the gen_jfix code and help from ol' Benski <3 )
  • Fixed 'QUEUE' entries appearing in the playlist when using the 'Enqueue and Play' mode and Winamp was not started intially
  • Fixed handling of 'Enqueue and Play' when the option to start Winamp if not already playing and using the add to Queue feature is in use (will force Winamp to start playing the first entry in the current queue)
  • Fixed a stack crash when pressing the 'defaults' button in the preferences do to a conflict in the Colouriser api (Build 6a change)
  • Checks to ensure where possible internal variables/buffers are correctly initialised where possible
  • Anthing else i forgot to note down...
---------------------------------------------------------

Hopefully now a lot of the bugs (especially a few left over from the original build #1) are gone now! Though the searching of extended characters really was a feature request... just a bit annoying jtfe was blamed for it *shrugs*

and now for the replies...

roytam1: please see http://forums.winamp.com/showthread....217490#reports since i can't say if the apparent speed issue you're having is mainly due to your system or not

jmatthews112: all the build 6 issues should be fixed in build 6a now (i hope )

YtseJam & jmatthews112: can you please confirm the colour settings are saving in build 6a (Egg confirmed a while back when the saving was added and my setup holds the values as well). also the information in the known issues will be updated tonight so that information will be removed (since it doesn't apply anymore )

Logy: http://www.google.co.uk/search?hl=en&q=c--+sphinx&meta= (basically a hybrid c + asm type language it seems)

TazDevil: i'll contact you over the weekend about the character translation stuff in the other jtfe thread in the dev forum that we had )

retchless: the shuffle thing has been on the todo list for a long time (as amano will probably remind me) but it was never working properly i found. with the extra time of things, i think it may be possible to get it working properly when i look at the code again so will have to see what happens with one of the next few builds (hopefully)

as for the return to the track that was to be next before the queue was started, i need that for the scheduler so that will be implemented soon as well i hope

-daz

edit:: finally updated the site with the changes (work/personal issues sort of delayed this :/ )
DrO is offline   Reply With Quote
Old 17th June 2005, 14:17   #124
YtseJam
Forum King
 
YtseJam's Avatar
 
Join Date: Dec 2000
Location: Israel
Posts: 2,399
Send a message via ICQ to YtseJam Send a message via AIM to YtseJam
So far the colours are still there.
I can also view Hebrew text correctly, dunno if that was an issue before.

Waiting for the scheduler!

YtseJam is offline   Reply With Quote
Old 17th June 2005, 14:57   #125
jmatthews112
Major Dude
 
Join Date: Jun 2003
Posts: 1,661
Send a message via AIM to jmatthews112 Send a message via Yahoo to jmatthews112
@daz

Seems to work for me as well. Another small quirk I noticed (as I don't usually select custom colors in the coloriser myself): Unless the checkboxes for "Use the existing color options (as above)" "Use separate color for the main text" and "Use separate color for time entry text" are checked, the color doesn't show in the preview box and instead, the pale looking checkbox for defaults shows (or whatever that is ). Not to worry too much though, because the color selected does appear once the checkbox is checked (is also likely that it is saved between sessions, but I haven't tested this myself).

@YtseJam

Quote:
Originally posted by DrO
[*]Added in foreign character handling in the jtf search (base implementation part derived from the gen_jfix code and help from ol' Benski <3 )

-daz
Your ability to view Hebrew likely stems from that.
jmatthews112 is offline   Reply With Quote
Old 17th June 2005, 15:17   #126
roytam1
Member
 
Join Date: Aug 2003
Posts: 81
Quote:
Originally posted by DrO

and now for the replies...

roytam1: please see http://forums.winamp.com/showthread....217490#reports since i can't say if the apparent speed issue you're having is mainly due to your system or not
-daz
My specs:
AMD Athlon XP 2600+
1GB DDR333 RAM
Sound Blaster Live! Value + KX Driver
WinXP SP1 Traditional Chinese Edition

How to reproduce:
open a playlist that has more then 600 entries, and then press [J] key to call JTFE, be sure you're in search mode, click right button and then select [Enqueue Options] -> [Add current search into queue]
You can see that JTFE add first 100 fast but it slows down in the followings, in adding 800th enties JTFE work slowly like a snail.

Plug-in list:
installed Winamp plugin list
Plugin directory is: C:\Program Files\Winamp\Plugins\

<< Input plugins >>

Monkey's Audio Player v3.99 [in_APE.dll]
Nullsoft CD/LineIn plug-in (CDDB2) v3.06 [in_cdda.dll]
CD Reader v1.95 (x86) [in_CDReader.dll]
Nullsoft DirectShow Decoder v0.94 [in_dshow.dll]
Reference FLAC Decoder v1.1.1 [in_flac.dll]
LPAC Decoder plug-in v1.00 (x86) [in_lpac.dll]
MAD plug-in 0.14.2b [in_mad.dll]
Nullsoft MIDI player 3.07 [in_midi.dll]
Mjuice Secure MP3 Decoder (x86) [in_mjf.dll]
Nullsoft Module Decoder v2.2.11 (x86) [in_mod.dll]
Nullsoft MPEG(Layer1-3/CT AAC+/Dolby AAC) Audio Decoder 3.09 [in_mp3.dll]
Nullsoft MP4 demuxer v0.5 [in_mp4.dll]
.mpc Musepack plugin 0.99f [in_mpc.dll]
Shibatch mpg123 plug-in v1.18y ot83a SSE [in_mpg123.dll]
Nullsoft NSV Decoder v1.05 [in_nsv.dll]
OptimFROG Lossless/DualStream Decoder v1.07 [in_ofr.dll]
inFMPMD v1.4.0 (x86) [in_pmd.dll]
Nullsoft Quicktime Decoder v0.1 [in_qt.dll]
innover's RealAudio plugin for Winamp v1.6 (x86) [in_ra.dll]
Winamp2 SPC player v2.06 [in_spc.dll]
Speex decoder v0.7.5a (x86) [in_speex.dll]
Nullsoft Tone Generator v0.0 (x86) [IN_TONE.DLL]
TTA Audio Decoder v3.1 (x86) [in_tta.dll]
Valex's AC3 decoder for Winamp v0.60b [in_vac3.dll]
Nullsoft Vorbis Decoder v1.40 [in_vorbis.dll]
Nullsoft Waveform Decoder v2.06 [in_wave.dll]
Nullsoft WMA plug-in v2.1(x86) [in_wm.dll]
WavPack Player v2.2 (x86) [in_wv.dll]
in_zip v0.5.0 [in_zip.dll]

<< Output plugins >>

ASIO output plug-in (dll version) v0.55 SSE [out_asio(dll).dll]
ASIO output plug-in (exe version) v0.57 SSE [out_asio(exe).dll]
ASIO output plug-in v0.33 [out_asio.dll]
Nullsoft Disk Writer plug-in v2.0c (x86) [out_disk.dll]
DirectSound output v2.31 (d) [out_ds.dll]
Experimental DirectSound output v1.4 [out_ds2.dll]
DirectSound output v2.2.6 SSRC [out_ds_ssrc.dll]
File Writer output plugin v1.17(c) (x86) [out_filewrite.dll]
Simple Kernel Streaming Output [out_ks.dll]
Nullsoft NULL Output Plug-In v1.0 beta (x86) [out_null.dll]
Speed plug-in v0.02 [out_speed.dll]
waveOut output v2.1 (d) [out_wave.dll]
Nullsoft WMA Output plug-in v0.90 (x86) [out_wm.dll]
Nullsoft Crossfading Output v0.95 (x86) (experimental) [out_xf.dll]

<< Visualisation plugins >>

Advanced Visualization Studio v2.81b [vis_avs.dll]
MilkDrop 1.04b [vis_milk.dll]
Nullsoft Tiny Fullscreen 2001 (v2.05) [vis_nsfs.dll]

<< DSP plugins >>

oddcast DSP v3 [dsp_oddcast_v3.dll]
Nullsoft SHOUTcast Source DSP v1.8.2b [dsp_sc.dll]
Nullsoft Signal Processing Studio DSP v0.36 [dsp_sps.dll]

<< General Purpose plugins >>

ActiveWinamp - v1.0 [gen_activewa.dll]
DoSomething Plugin (gen_dosomething.dll)
Nullsoft Modern Skins Support v1.06 [gen_ff.dll]
Nullsoft Global Hotkeys v1.3 [gen_hotkeys.dll]
Jump To File Extra v0.97 R (Build 6a) [gen_jumpex.dll]
Nullsoft Winamp Library v2.14 [gen_ml.dll]
MessengerAmp v2.0 (gen_msn.dll)
One for Nunz v1.5 [gen_nunzio.dll]
Skinned Preferences v0.49.8 [gen_prefs_skin.dll]
Titlebar Info 1.47 (gen_tbar_2.dll)
Tips v0.4 [gen_tips.dll]
Nullsoft Tray Control v0.2 [gen_tray.dll]
VS.com Client v0.92 [Stopped] [gen_ViralSound.dll]
Niver's Tray Controls Plug-In v1.5.1 (gen_WinAmpTray.dll)
YunaSoft SexyFont Plug-in 2000 v7.9b21 [gen_yuna.dll]

<< Media Library plugins >>

ATF Extender v0.4 [ml_atfext.dll]
ActiveWA support


Contents of debugdmp.txt generated when winamp exit:

Unhandled exception: 06/17/2005 22:09:01
Exception code: C0000005 ACCESS_VIOLATION
Fault address: 048D722A 00:00000000 C:\Program Files\Winamp\Plugins\gen_jumpex.dll

Registers:
EAX:00000022
EBX:048EBEC8
ECX:77F59037
EDX:00F10002
ESI:04C4101D
EDI:00000000
CS:EIP:001B:048D722A
SS:ESP:0023:04D5ECF8 EBP:04D5ED20
DS:0023 ES:0023 FS:003B GS:0000
Flags:00010206

Call stack:
Address Frame
048D722A 04D5ED200000:00000000 C:\Program Files\Winamp\Plugins\gen_jumpex.dll
048D767B 04D5F66C0000:00000000 C:\Program Files\Winamp\Plugins\gen_jumpex.dll
048D77E3 04D6F68C0000:00000000 C:\Program Files\Winamp\Plugins\gen_jumpex.dll

77E79BF5 04D6FBB40000:00000000 C:\WINDOWS\system32\kernel32.dll
77E7F33C 04D6FFEC0000:00000000 C:\WINDOWS\system32\kernel32.dll

Loaded Modules:
Winamp.exe Load Address: 0x400000 - 0x52C000 (1200k)
( C:\Program Files\Winamp\Winamp.exe )
ntdll.dll Load Address: 0x77F50000 - 0x77FF7000 (668k)
( C:\WINDOWS\System32\ntdll.dll )
kernel32.dll Load Address: 0x77E40000 - 0x77F4F000 (1084k)
( C:\WINDOWS\system32\kernel32.dll )
COMCTL32.dll Load Address: 0x78090000 - 0x78175000 (916k)
( C:\WINDOWS\WinSxS\X86_Microsoft.Windows.Common-Controls...\COMCTL32.dll )
msvcrt.dll Load Address: 0x77BE0000 - 0x77C33000 (332k)
( C:\WINDOWS\system32\msvcrt.dll )
GDI32.dll Load Address: 0x7F000000 - 0x7F041000 (260k)
( C:\WINDOWS\system32\GDI32.dll )
USER32.dll Load Address: 0x77D10000 - 0x77D9B000 (556k)
( C:\WINDOWS\system32\USER32.dll )
ADVAPI32.dll Load Address: 0x77DA0000 - 0x77E39000 (612k)
( C:\WINDOWS\system32\ADVAPI32.dll )
RPCRT4.dll Load Address: 0x78000000 - 0x78087000 (540k)
( C:\WINDOWS\system32\RPCRT4.dll )
SHLWAPI.dll Load Address: 0x70A70000 - 0x70AD6000 (408k)
( C:\WINDOWS\system32\SHLWAPI.dll )
MSACM32.dll Load Address: 0x77BB0000 - 0x77BC4000 (80k)
( C:\WINDOWS\System32\MSACM32.dll )
WINMM.dll Load Address: 0x76B10000 - 0x76B39000 (164k)
( C:\WINDOWS\System32\WINMM.dll )
comdlg32.dll Load Address: 0x76320000 - 0x76363000 (268k)
( C:\WINDOWS\system32\comdlg32.dll )
SHELL32.dll Load Address: 0x773A0000 - 0x77B78000 (8032k)
( C:\WINDOWS\system32\SHELL32.dll )
ole32.dll Load Address: 0x4FEC0000 - 0x4FFF6000 (1240k)
( C:\WINDOWS\system32\ole32.dll )
IMM32.DLL Load Address: 0x76300000 - 0x7631C000 (112k)
( C:\WINDOWS\System32\IMM32.DLL )
LPK.DLL Load Address: 0x621F0000 - 0x621F8000 (32k)
( C:\WINDOWS\System32\LPK.DLL )
USP10.dll Load Address: 0x72F10000 - 0x72F6A000 (360k)
( C:\WINDOWS\System32\USP10.dll )
MsgPlusLoader.dll Load Address: 0x10000000 - 0x1000E000 (56k)
( C:\WINDOWS\System32\MsgPlusLoader.dll )
INDICDLL.dll Load Address: 0x656C0000 - 0x656C6000 (24k)
( C:\WINDOWS\System32\INDICDLL.dll )
CLBCATQ.DLL Load Address: 0x7A170000 - 0x7A1F1000 (516k)
( C:\WINDOWS\System32\CLBCATQ.DLL )
OLEAUT32.dll Load Address: 0x770F0000 - 0x7717B000 (556k)
( C:\WINDOWS\system32\OLEAUT32.dll )
COMRes.dll Load Address: 0x77020000 - 0x770E5000 (788k)
( C:\WINDOWS\System32\COMRes.dll )
VERSION.dll Load Address: 0x77BD0000 - 0x77BD7000 (28k)
( C:\WINDOWS\system32\VERSION.dll )
shdocvw.dll Load Address: 0x71700000 - 0x7184A000 (1320k)
( C:\WINDOWS\System32\shdocvw.dll )
msctfime.ime Load Address: 0xB40000 - 0xB6B000 (172k)
( C:\WINDOWS\System32\msctfime.ime )
WININET.dll Load Address: 0x63000000 - 0x63095000 (596k)
( C:\WINDOWS\system32\WININET.dll )
CRYPT32.dll Load Address: 0x76230000 - 0x762B8000 (544k)
( C:\WINDOWS\system32\CRYPT32.dll )
MSASN1.dll Load Address: 0x76210000 - 0x76220000 (64k)
( C:\WINDOWS\system32\MSASN1.dll )
Secur32.dll Load Address: 0x76F60000 - 0x76F70000 (64k)
( C:\WINDOWS\System32\Secur32.dll )
wsock32.dll Load Address: 0x71A30000 - 0x71A3A000 (40k)
( C:\WINDOWS\System32\wsock32.dll )
WS2_32.dll Load Address: 0x71A10000 - 0x71A25000 (84k)
( C:\WINDOWS\System32\WS2_32.dll )
WS2HELP.dll Load Address: 0x71A00000 - 0x71A08000 (32k)
( C:\WINDOWS\System32\WS2HELP.dll )
read_file.dll Load Address: 0x13B0000 - 0x13CB000 (108k)
( C:\Program Files\Winamp\Plugins\read_file.dll )
WINSPOOL.DRV Load Address: 0x72F70000 - 0x72F93000 (140k)
( C:\WINDOWS\System32\WINSPOOL.DRV )
DSOUND.dll Load Address: 0x51080000 - 0x510E1000 (388k)
( C:\WINDOWS\System32\DSOUND.dll )
wdmaud.drv Load Address: 0x72C90000 - 0x72C99000 (36k)
( C:\WINDOWS\System32\wdmaud.drv )
msacm32.drv Load Address: 0x72C80000 - 0x72C88000 (32k)
( C:\WINDOWS\System32\msacm32.drv )
midimap.dll Load Address: 0x77BA0000 - 0x77BA7000 (28k)
( C:\WINDOWS\System32\midimap.dll )
ogg.dll Load Address: 0x3E00000 - 0x3E09000 (36k)
( C:\Program Files\Winamp\ogg.dll )
vorbis.dll Load Address: 0x3E10000 - 0x3F25000 (1108k)
( C:\Program Files\Winamp\vorbis.dll )
SETUPAPI.dll Load Address: 0x765E0000 - 0x7672A000 (1320k)
( C:\WINDOWS\System32\SETUPAPI.dll )
TAPI32.dll Load Address: 0x76E80000 - 0x76EAB000 (172k)
( C:\WINDOWS\System32\TAPI32.dll )
rtutils.dll Load Address: 0x76E50000 - 0x76E5D000 (52k)
( C:\WINDOWS\System32\rtutils.dll )
UxTheme.dll Load Address: 0x5A410000 - 0x5A443000 (204k)
( C:\WINDOWS\System32\UxTheme.dll )
ddraw.dll Load Address: 0x51000000 - 0x51050000 (320k)
( C:\WINDOWS\System32\ddraw.dll )
DCIMAN32.dll Load Address: 0x73B30000 - 0x73B36000 (24k)
( C:\WINDOWS\System32\DCIMAN32.dll )
gen_activewa.dll Load Address: 0x47B0000 - 0x47DF000 (188k)
( C:\Program Files\Winamp\Plugins\gen_activewa.dll )
gen_dosomething.dll Load Address: 0x47E0000 - 0x48B1000 (836k)
( C:\Program Files\Winamp\Plugins\gen_dosomething.dll )
gen_ff.dll Load Address: 0x1A100000 - 0x1A337000 (2268k)
( C:\Program Files\Winamp\Plugins\gen_ff.dll )
OLEPRO32.DLL Load Address: 0x5E5C0000 - 0x5E5DA000 (104k)
( C:\WINDOWS\System32\OLEPRO32.DLL )
gen_hotkeys.dll Load Address: 0x48C0000 - 0x48C8000 (32k)
( C:\Program Files\Winamp\Plugins\gen_hotkeys.dll )
gen_jumpex.dll Load Address: 0x48D0000 - 0x48F5000 (148k)
( C:\Program Files\Winamp\Plugins\gen_jumpex.dll )
IMAGEHLP.dll Load Address: 0x76C60000 - 0x76C82000 (136k)
( C:\WINDOWS\system32\IMAGEHLP.dll )
gen_ml.dll Load Address: 0x10720000 - 0x107A8000 (544k)
( C:\Program Files\Winamp\Plugins\gen_ml.dll )
wldap32.dll Load Address: 0x76F30000 - 0x76F5C000 (176k)
( C:\WINDOWS\system32\wldap32.dll )
SXS.DLL Load Address: 0x75E00000 - 0x75EAB000 (684k)
( C:\WINDOWS\System32\SXS.DLL )
mswsock.dll Load Address: 0x719B0000 - 0x719EB000 (236k)
( C:\WINDOWS\System32\mswsock.dll )
DNSAPI.dll Load Address: 0x76EF0000 - 0x76F15000 (148k)
( C:\WINDOWS\System32\DNSAPI.dll )
Msimtf.dll Load Address: 0x74650000 - 0x74676000 (152k)
( C:\WINDOWS\System32\Msimtf.dll )
MSCTF.dll Load Address: 0x74680000 - 0x746C4000 (272k)
( C:\WINDOWS\System32\MSCTF.dll )
winrnr.dll Load Address: 0x76F80000 - 0x76F87000 (28k)
( C:\WINDOWS\System32\winrnr.dll )
rasadhlp.dll Load Address: 0x76F90000 - 0x76F95000 (20k)
( C:\WINDOWS\System32\rasadhlp.dll )
wshtcpip.dll Load Address: 0x719F0000 - 0x719F8000 (32k)
( C:\WINDOWS\System32\wshtcpip.dll )
WNMKEY.DLL Load Address: 0x5460000 - 0x546C000 (48k)
( F:\app_related\scj71\WNMKEY.DLL )
kxapi.dll Load Address: 0x54A0000 - 0x5500000 (384k)
( c:\windows\system32\kxapi.dll )
kxgui.dll Load Address: 0x5500000 - 0x5557000 (348k)
( c:\windows\system32\kxgui.dll )
MFC42D.DLL Load Address: 0x5F400000 - 0x5F4E5000 (916k)
( c:\windows\system32\MFC42D.DLL )
MSVCRTD.dll Load Address: 0x10200000 - 0x1026C000 (432k)
( c:\windows\system32\MSVCRTD.dll )
MSIMG32.dll Load Address: 0x762F0000 - 0x762F5000 (20k)
( c:\windows\system32\MSIMG32.dll )
MFC42LOC.DLL Load Address: 0x611C0000 - 0x611C9000 (36k)
( C:\WINDOWS\System32\MFC42LOC.DLL )
KsUser.dll Load Address: 0x5EF80000 - 0x5EF84000 (16k)
( C:\WINDOWS\System32\KsUser.dll )
RASAPI32.DLL Load Address: 0x76EB0000 - 0x76EE7000 (220k)
( C:\WINDOWS\System32\RASAPI32.DLL )
rasman.dll Load Address: 0x76E60000 - 0x76E71000 (68k)
( C:\WINDOWS\System32\rasman.dll )
NETAPI32.dll Load Address: 0x71BA0000 - 0x71BEE000 (312k)
( C:\WINDOWS\System32\NETAPI32.dll )
sensapi.dll Load Address: 0x72240000 - 0x72245000 (20k)
( C:\WINDOWS\System32\sensapi.dll )
USERENV.dll Load Address: 0x759D0000 - 0x75A70000 (640k)
( C:\WINDOWS\system32\USERENV.dll )
urlmon.dll Load Address: 0x1A400000 - 0x1A47D000 (500k)
( C:\WINDOWS\system32\urlmon.dll )
DBGHELP.dll Load Address: 0x6D820000 - 0x6D89D000 (500k)
( C:\WINDOWS\system32\DBGHELP.dll )

Generated by JTFE
JTFE version: v0.97 R (Build 6a)
Winamp verison: 0.
roytam1 is offline   Reply With Quote
Old 17th June 2005, 15:41   #127
jmatthews112
Major Dude
 
Join Date: Jun 2003
Posts: 1,661
Send a message via AIM to jmatthews112 Send a message via Yahoo to jmatthews112
@roytam:

What happens on a clean install? It may be a conflict between third-party plugins and JTFE. I'd suggest following those instructions exactly, and then upon your second install replacing each third-party plugin one-by-one until one causes a serious lag with Winamp and JTFE. If it doesn't help, post that back here.

If I'm not mistaken, gen_dosomething has been known to cause problems...looking at the loaded modules.

[edit@dro]

When the 'Disable the sorting of the Jump to File search results' is unchecked, the results in Search mode are sorted correctly--most of the time. If files are queued, and the queue is cleared, the search mode retains the order listed before the queue was cleared, even after the JTF dialog is closed and regardless of any new queue that is generated. Sometimes, it seemed, lower ranking/later files came before higher ranking/earlier files in the search results. Perhaps the two issues are interconnected/related?

I do like how the search results seems to sort dynamically and that you don't have to close the dialog between views for it to update correctly (extensions still show until the dialog is closed and reopened, however, UNLESS the file is queued).

Also you might want to point out that the aforementioned option is tied to the first item in the new changelog, is kind of confusing/ambigious.

[/edit]

Last edited by jmatthews112; 17th June 2005 at 16:12.
jmatthews112 is offline   Reply With Quote
Old 17th June 2005, 16:05   #128
roytam1
Member
 
Join Date: Aug 2003
Posts: 81
Quote:
Originally posted by jmatthews112
@roytam:

What happens on a clean install? It may be a conflict between third-party plugins and JTFE. I'd suggest following those instructions exactly, and then upon your second install replacing each third-party plugin one-by-one until one causes a serious lag with Winamp and JTFE. If it doesn't help, post that back here.

If I'm not mistaken, gen_dosomething has been known to cause problems...looking at the loaded modules.
I found that my old TitleBar Info 1.47 crashes winamp on exit. I did a update of gen_tbar_2 and it no more crashed.
And this time JTFE addes 212 entries into queue and then Winamp stop responding but the song still playing.
roytam1 is offline   Reply With Quote
Old 18th June 2005, 15:11   #129
Cadish
Junior Member
 
Join Date: Jan 2004
Posts: 31
I don't get it: if I have e.g. "Mylo - Drop The Pressure" in my playlist, and I use JTFE to search for this song:

I type "Mylo drop" and it's not giving any search result...

This used to work until Build 6...
Cadish is offline   Reply With Quote
Old 18th June 2005, 15:24   #130
DrO
 
Join Date: Sep 2003
Posts: 27,873
i need to do more work on the new search function since as i indicated in the changelog for build 6/6a that i now handle the searching.

-daz
DrO is offline   Reply With Quote
Old 18th June 2005, 16:15   #131
siebe83
Forum King
 
siebe83's Avatar
 
Join Date: Feb 2004
Posts: 9,222
Great work!
I like to have all my music in the playlist and turn on shuffle. When I want to hear a specific album I can now just hit J, type artist + album and add the search into queue and they will play in the right order
(and afterwards it'll continue shuffling)

And I love the middle mouse button queueing songs

Good Winamp plugins by Joonas, DrO and shaneh.
If you're bored go here or, if the boredom is more serious, here.
siebe83 is offline   Reply With Quote
Old 18th June 2005, 18:30   #132
electricmime
Major Dude
 
Join Date: Mar 2004
Posts: 991
siebe: how does that album thing work? do you just have all your stuff titled with track numbers and albums in it?

and also.. i just noticed, it only sees the exact stuff i type in.. for example if i type in 'pixies al ' it doesnt display anything

if i used to type in 'pixies al' it would show anything with 'pixies' and 'al' in it.. and not anything with 'pixies al '...

actually, i have to type in the - if i want to get a band and a title ('pixies - allison' works while 'pixies allison' does not)

however, if i just type in the album(which is not in the title because i keep my songs listed as 'band - song title' it picks it up(as long as i don't add any other info like band or song name)

is there some option to turn that off that i didnt see?

There is no reset button on life... but the graphics kick ass
electricmime is offline   Reply With Quote
Old 18th June 2005, 18:47   #133
siebe83
Forum King
 
siebe83's Avatar
 
Join Date: Feb 2004
Posts: 9,222
My playlist is sorted on filename, and my files are named 'artist - album\artist - track# - title'

But I don't have tracknumber in my ATF string, so in the past JTF would always just sort on 'artist - title'. Now they appear in the playlist (correct) order (if that option is checked, that is).

Apart from adding the album into queue it also comes in handy when you want to jump to the first song of an album (if you don't have track# displayed in playlist...).


As for the search not working properly, see a few posts up: Cadish reported the same and DrO already replied.

Good Winamp plugins by Joonas, DrO and shaneh.
If you're bored go here or, if the boredom is more serious, here.
siebe83 is offline   Reply With Quote
Old 18th June 2005, 18:57   #134
electricmime
Major Dude
 
Join Date: Mar 2004
Posts: 991
Quote:
Originally posted by siebe83
As for the search not working properly, see a few posts up: Cadish reported the same and DrO already replied.
nevermind then, lol

There is no reset button on life... but the graphics kick ass
electricmime is offline   Reply With Quote
Old 18th June 2005, 20:41   #135
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 6b is out:: release info

[temp changelog until i get home and can upload to the site]
  • Adjusted how the new JTFE handled search function works to better match the orignal Winamp function but still keeping the new extended character support
---------------------------------------------------------

This should more closely match the original winamp search function (it makes a change for the 'bugs' in the searching to be my fault now )

-daz
DrO is offline   Reply With Quote
Old 20th June 2005, 01:18   #136
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 7a is out:: release info

---------------------------------------------------------

The scheduler begins... there's a lot to still go in (and i mean a lot) but as a preview, etc of how things will be going can now be seen (there's a few things which aren't stable enough for public testing quite yet )

There's a few replies to issues that i need to reply to but it's late here and i've a long day at work tomorrow i think, so i'll deal with things tomorrow... though i assume by the silence that the fix in #6b was met with approval?

edit:
Egg found a bug just after i released build #7 so i've fixed that and at the same time tracked down and hopefully fixed the slow down issues roytam1 was experiencing (one of my optimsations was lost in the code crash and that was what it had been for but it should be all fixed now )

-daz
DrO is offline   Reply With Quote
Old 20th June 2005, 04:40   #137
Spazz333
Major Dude
 
Spazz333's Avatar
 
Join Date: Nov 2003
Location: Limbo
Posts: 1,498
I might be the only one this would help but here goes. I have my main playlist being all my 4 star songs added twice, 5 star added 3 times and it would be nice if the JTF window could filter out duplicates. By filename or by the title reading exactly the same.

::edit:: Oh, and being able to middle click to enqueue files in the Library would rock also.

Spazz333 is offline   Reply With Quote
Old 20th June 2005, 05:37   #138
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
I dont do that but from now on when ppl ask for winamp's random to take into account song ratings, thats what im gonna tell them to do.

smart thinking
billyvnilly is offline   Reply With Quote
Old 20th June 2005, 05:43   #139
Spazz333
Major Dude
 
Spazz333's Avatar
 
Join Date: Nov 2003
Location: Limbo
Posts: 1,498
I wish I'd thought of it. I just mercilessly stole the idea.

I actually do wish winamp would take ratings into account but this works fine for the time being. Better this than Itunes.

Spazz333 is offline   Reply With Quote
Old 20th June 2005, 13:30   #140
DrO
 
Join Date: Sep 2003
Posts: 27,873
the filtering of duplicates is possible however... it would give a bit of speed hit on the search since the search function is just passed the playlist entries so extra processing would be needed to check if it's already been added or not.

i'll look into it for one of the next two builds (seeing as i have the power of the search function now, hehe :evilgrin: )

with the middle click enqueue in the ml, i'm not sure at what stage that will be going in (since any of those things involves a bit more hacking into the ml and i need to make sure that doing so won't mess up any of the existing ml actions/handling) but it's noted now

-daz
DrO is offline   Reply With Quote
Old 22nd June 2005, 07:25   #141
Cadish
Junior Member
 
Join Date: Jan 2004
Posts: 31
It would be great if you also can remove a file from the queue by pressing the middle mouse button.
E.g.: I press the middle mouse button in my playlist, so the selected song is enqueued. I enqueue some other songs, and then I press the middle mouse button again on the first song. This song is then removed from my queue-list
Cadish is offline   Reply With Quote
Old 22nd June 2005, 08:46   #142
electricmime
Major Dude
 
Join Date: Mar 2004
Posts: 991
Quote:
Originally posted by Cadish
It would be great if you also can remove a file from the queue by pressing the middle mouse button.
E.g.: I press the middle mouse button in my playlist, so the selected song is enqueued. I enqueue some other songs, and then I press the middle mouse button again on the first song. This song is then removed from my queue-list

under the jtfe prefs->enqueue options->playlist editor options->check remove file from queue on alt-click if already in the queue list

im pretty sure it works for both(since my middle click removes songs from the queue) and it also works for hitting 'q' i believe

There is no reset button on life... but the graphics kick ass
electricmime is offline   Reply With Quote
Old 22nd June 2005, 08:54   #143
Cadish
Junior Member
 
Join Date: Jan 2004
Posts: 31
Oh, thanks man!! This is just wonderful!
Cadish is offline   Reply With Quote
Old 22nd June 2005, 09:19   #144
DrO
 
Join Date: Sep 2003
Posts: 27,873
that's the way to do it and that prefs option will be re-named

-daz
DrO is offline   Reply With Quote
Old 22nd June 2005, 18:43   #145
Streproyt
Junior Member
 
Join Date: Jun 2005
Posts: 4
I have found a couple of issues/possible bugs related to the colouriser stuff:

1) In classic skin if you uncheck the option "span the highlight colour across the full qued item" the titles of the qued files in the playlist disappear being totally "invisible" (you only can see the black background of the playlist). I think this is due to the colour for the main text is black by default in the colouriser options, but I have changed it, playing with different combinations of colours and still it isn't visible, unless you check the span the hightlight colour... option.

This doesn't happen with the modern skin, only with the classic (the one I use), I have tried it with a clean install of winamp 5.093 and it still happens. Something curious about this is that if you change to modern skin and then go back to classic skin it is fixed temporary, until the next time you open again winamp.

Can someone please reproduce this? or it is something to do with my system?... not a big deal just a little annoying.

2) The show entry option doesn't flash with the qued files, only works with the non qued files.
Streproyt is offline   Reply With Quote
Old 23rd June 2005, 00:14   #146
jmatthews112
Major Dude
 
Join Date: Jun 2003
Posts: 1,661
Send a message via AIM to jmatthews112 Send a message via Yahoo to jmatthews112
I seem to be able to confirm Streproyt's bugs/issues in their entirety using a clean install of Winamp 5.093 on a WinXP Pro SP2 system. The first issue seems most noticeable on the Winamp Classic skin when you uncheck 'Highlight background of queued items in playlist' [the entire line within the playlist is hidden] although the above option hides the entry up until the time portion. This is using the default color selections, and I also tend to have 'Blend color' checked as well. Otherwise good work and I am looking forward to the scheduler. jmat
jmatthews112 is offline   Reply With Quote
Old 23rd June 2005, 01:26   #147
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 8 is out:: release info

---------------------------------------------------------

Streproyt: #1 was a bug in the code, #2 is an implemented feature in the colouriser api where multiple items affected by the colouriser won't process further after the first match. this will be looked into soon

-daz
DrO is offline   Reply With Quote
Old 23rd June 2005, 01:54   #148
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
the "highlight background of queued items in playlist" is the same color as "highlight background of missing file entries in the playlist" in preferences and if you change one, it changes the other. But missing file is always bluebackground in pledit. i guess its still under dev

since you colorizing things...I'd love to see colored separators.

night dro
billyvnilly is offline   Reply With Quote
Old 23rd June 2005, 10:38   #149
Cadish
Junior Member
 
Join Date: Jan 2004
Posts: 31
Hi,

There is one function I always wanted in winamp/jtf. It was a function of Winamp3.
If you jump to a file, and then you press next, and then previous, another song is played, than the one you jumped to.

It would be great if that could be an option!!
Cadish is offline   Reply With Quote
Old 23rd June 2005, 20:24   #150
glop
Senior Member
 
Join Date: Dec 2002
Location: Paris
Posts: 454
great great...BUT !

Even if you can doubble clic on "missing file"
they are two "elevators" in the winamp preferences

see what i mean
http://skeksess.free.fr/jtfe.jpg

perhaps it should be inside the preferences in a section as Display or Enqueue List ?
glop is offline   Reply With Quote
Old 23rd June 2005, 23:10   #151
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
dro intended for it to be like that.
billyvnilly is offline   Reply With Quote
Old 24th June 2005, 01:49   #152
DrO
 
Join Date: Sep 2003
Posts: 27,873
Build 9 is out:: release info

---------------------------------------------------------

billyvnilly: your issue should be fixed (and playlist separator will get colouring once the api is finalised)

Cadish: you've lost me there (and Egg as well )

glop: as billyvnilly replied, it's by design since it's not directly a jtfe feature but it's related to what jtfe provides it (and i felt a prefs page in the main jtfe prefs wasn't right for it)

and i sleep (late again )

-daz
DrO is offline   Reply With Quote
Old 24th June 2005, 02:08   #153
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
night dro

@cadish, why would you need to hit next and then previous? ...if you want a unique song that is.
billyvnilly is offline   Reply With Quote
Old 24th June 2005, 03:12   #154
billyvnilly
Forum King, M.D.
 
billyvnilly's Avatar
 
Join Date: Mar 2004
Location: Detroit burbs
Posts: 3,379
Send a message via ICQ to billyvnilly Send a message via AIM to billyvnilly
got a crash dragging and dropping from ML. not sure but i think it was on a track change. but cant reproduce.
Attached Files
File Type: txt debugdmp.txt (11.4 KB, 636 views)
billyvnilly is offline   Reply With Quote
Old 24th June 2005, 03:30   #155
jmatthews112
Major Dude
 
Join Date: Jun 2003
Posts: 1,661
Send a message via AIM to jmatthews112 Send a message via Yahoo to jmatthews112
The fixes for "Added in non adding of the ML send to: menus if no items can be found in the database (hopefully the 'filename ISNOTEMPTY' query is fine for this)" seem to be working well on a clean install of Winamp 5.093 on a WinXP Pro SP2 system.

Based on simple tests regarding the "Fixed a bug where the colouriser and missing file features were sharing the same selection colour when they shouldn't have" issue, the default color for "Blend color with playlist background" seems to remain the same for both (blue) when using the Winamp Classic skin. I do recognize however that the text for enqueued files appears white by default with this skin [apparently a feature of JTFE], while missing files display text retains the default color as pulled from the skin (green). Hopefully that didn't confuse anyone, and I hope I'm not missing anything with regard to the intent of the feature. Bug, I don't know, but I guess we will find out soon. that's all I have for now, jmat.

btw, fixes for "Altered the colouriser api to enum all callbacks now so that mutliple actions ill be blended together for that entry (like queued and the show in the playlist option is used)" work well as far as I can tell (I remember there being concern for the inability of JTFE to show queued files by the Show Entry method...
jmatthews112 is offline   Reply With Quote
Old 24th June 2005, 07:13   #156
Cadish
Junior Member
 
Join Date: Jan 2004
Posts: 31
Quote:
Originally posted by billyvnilly
@cadish, why would you need to hit next and then previous? ...if you want a unique song that is.
If you just jumped to a file, and the song ends, so another song plays, you think: what a beautiful song (the previous), and you hit previous... So you have to jump to the song again in order to hear it

Many of my friends want this feature too. I find this very odd that nobody asks for it here...
Cadish is offline   Reply With Quote
Old 24th June 2005, 10:29   #157
macaroon
Major Dude
 
macaroon's Avatar
 
Join Date: Mar 2001
Location: UK
Posts: 619
DrO

Currently running WA 2.81 and it's jumpin' fine! I'm a happy man (And it's not often enough that I say that these days) Keep up the good work!

Winamp 5 updates Spilt_Milk
macaroon is offline   Reply With Quote
Old 24th June 2005, 13:39   #158
DrO
 
Join Date: Sep 2003
Posts: 27,873
Cadish: gotcha, and amano wanted it as well

macaroon: cool, i haven't properly been able to test things on any of the 2.x versions in a long time so it's good to hear it's actually working

billyvnilly: i'll see if i can track down the code at that crash location and see if there is something not right

jmatthews112: with the blend colour thing, the default is meant to be the same for both since that's how the internal api works the issue was when a custom colour was set for either of them since in the copy + paste i'd been doing from jtfe to the dev plugin and back into jtfe i'd managed to duplicate the same colour variable.

As for the colour of the text, it should be using the same colour if the defaults are in use so for the classic base skin it should be green (or white if it's the currently playing track)

on a general request, has anyone seen any issues with the search results since i don't think i've borken it in the change i made to the comparison function last night but some confirmation (especially with foreign/extended characters in upper/lower case combinations)

-daz
DrO is offline   Reply With Quote
Old 24th June 2005, 14:09   #159
glop
Senior Member
 
Join Date: Dec 2002
Location: Paris
Posts: 454
Quote:
it's by design since it's not directly a jtfe feature but it's related to what jtfe provides it (and i felt a prefs page in the main jtfe prefs wasn't right for it)
i understand but each time preferences are opened , the "elevators" are present, it's hugly...
glop is offline   Reply With Quote
Old 24th June 2005, 14:31   #160
retchless
Member
 
Join Date: Oct 2003
Location: Canada
Posts: 97
elevators == scroll bars?
retchless is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump