NSIS v2.51

[Anders]

One more round of security fixes and various other minor improvements. MakeNSIS will now give a warning if the output file is named "setup.exe" because Windows insecurely loads compatibility shims before any of our code runs for this specific filename.

Please report back if you are using plug-ins that require .NET WinForms or GDI+ and are having issues on Windows 7. See MS Connect for the latest news on this issue.

Known issues:

• WinForms/GDI+ font failure on Win7 (NSIS 2.47-2.51 and 3.0b3+)

If you find any new issues, report them in this thread and/or on the SF bug tracker and please include compiler error messages and sample code if possible...

[T.Slappy]

That "setup.exe" thing:

The resulting setup cannot be named exactly "setup.exe" or any variant of "setup.exe" like "visual-installer-setup.exe" is bad?

[Anders]

Originally Posted by T.Slappy

The resulting setup cannot be named exactly "setup.exe" or any variant of "setup.exe" like "visual-installer-setup.exe" is bad?

Exactly "setup.exe", nothing else. Using this name on a read-only media like a CD/DVD is probably OK but files available for download should not use this name.

[kmoyse]

Hello,

I need to be able to generate a Windows executable at the end of a build process that is performed ona linux Ubuntu box. So i tried to compile a NSIS version on that linux box. But I meet the following issue :

kmoyse@terbium:~/opt/nsis-2.51-src$ uname -a
Linux terbium 3.2.0-101-generic #141-Ubuntu SMP Thu Mar 10 21:43:24 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
kmoyse@terbium:~/opt/nsis-2.51-src$ scons --version
SCons by Steven Knight et al.:
script: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on ubuntu
engine: v2.1.0.r5357[MODIFIED], 2011/09/09 21:31:03, by bdeegan on ubuntu
engine path: ['/usr/lib/scons/SCons']
Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 The SCons Foundation
kmoyse@terbium:~/opt/nsis-2.51-src$ python --version
Python 2.7.3


kmoyse@terbium:~/opt/nsis-2.51-src$ scons SKIPSTUBS=all SKIPPLUGINS=all SKIPUTILS=all SKIPMISC=all NSIS_CONFIG_CONST_DATA=no PREFIX=/home/kmoyse/opt/nsis-2.51 install-compiler
scons: Reading SConscript files ...
Mkdir("build/release/config")
Delete("nsis-16-Apr-2016.cvs")
Delete(".instdist")
Delete(".test")
Using GNU tools configuration
Checking for compiler flag -m32... (cached) yes
Checking for linker flag -m32... (cached) no
<snip>
Checking for C library dl... (cached) no
Checking for C library gdi32... (cached) no
Checking for C library iconv... (cached) no
Checking for C library pthread... (cached) no
Checking for C library user32... (cached) no
Checking for C++ library cppunit... (cached) no
scons: done reading SConscript files.
scons: Building targets ...
g++ -o build/release/makensis/build.o -c -Wno-non-virtual-dtor -Wall -O2 -m32 -DNSISCALL=__attribute__((__stdcall__)) -D_WIN32_IE=0x0500 -Ibuild/release/config Source/build.cpp
sh: 1: Syntax error: "(" unexpected
scons: *** [build/release/makensis/build.o] Error 2
scons: building terminated because of errors.

I think the issue come from the g++command parameter -DNSISCALL=__attribute__((__stdcall__)) which would work better if there were quotes, like : -DNSISCALL="__attribute__((__stdcall__))"...

How Can I workaround this ?

Thanks
Kevin

[Anders]

Yeah, sorry about that, apply the fix from https://sourceforge.net/p/nsis/code/6746/ already reported @ https://sourceforge.net/p/nsis/bugs/1139/

--- a/NSIS/branches/nsis2/SCons/Config/gnu
+++ b/NSIS/branches/nsis2/SCons/Config/gnu
@@ -31,7 +31,7 @@
defenv['CPP_REQUIRES_STDLIB'] = 1
defenv['SUBSYS_CON'] = '-Wl,--subsystem,console'
defenv['MSVCRT_FLAG'] = ''
-defenv['STDCALL'] = '__attribute__((__stdcall__))'
+defenv['STDCALL'] = '"__attribute__((__stdcall__))"'

[kmoyse]

Thanks !