Old 18th January 2007, 12:52   #1
pushingsquares
Junior Member
 
Join Date: Jan 2007
Posts: 5
Drag/dropping recursive link causes crash

Hello there!

I've just upgraded from version 2.8 to version 5.32 (x86) and found I could not drag/drop my entire music collection into your fantastic piece of software anymore

I had a think about it and flicked through my collection quickly and have worked it out for you!

Basically, if you drop a link which references the directory it is stored within (tee hee) into Winamp, it crashes!

Presumeably you've altered recursive searching in some way which now navigates links as well as directories! Admittedly, this is pretty cool, but it would probably be a good idea to add a check in there that ensures the link is not referencing its own dir (for those fools who might be stupid enough to do it ).

Once again, fantastic work. I am a Winamp (lite) addict and would use nothing else
pushingsquares is offline   Reply With Quote
Old 18th January 2007, 12:58   #2
pushingsquares
Junior Member
 
Join Date: Jan 2007
Posts: 5
Precise reproduction method

1. Create a folder
2. Create a link to the folder you created in step (1) inside it
3. Drag the folder you created in step (1) - or indeed the link - into Winamp

Winamp then crashes after a brief period of processing.
pushingsquares is offline   Reply With Quote
Old 18th January 2007, 13:22   #3
Koopa
16-Bit Moderator
 
Koopa's Avatar
 
Join Date: Apr 2004
Posts: 4,341
I can reproduce your crash, I'll report it to the devs, so we shall see.
Koopa is offline   Reply With Quote
Old 18th January 2007, 13:44   #4
pushingsquares
Junior Member
 
Join Date: Jan 2007
Posts: 5
woop woop!
pushingsquares is offline   Reply With Quote
Old 18th January 2007, 14:07   #5
DrO
 
Join Date: Sep 2003
Posts: 27,873
is already a known issue and really it's just a bad thing to do that sort of thing with shortcuts to the same folder within itself. since winamp can't/doesn't currently track the parent/previous folder that was opened it has no knowledge that it's entered into a recursive loop (as such a link causes).

-daz
DrO is offline   Reply With Quote
Old 19th January 2007, 12:18   #6
pushingsquares
Junior Member
 
Join Date: Jan 2007
Posts: 5
Quote:
since winamp can't/doesn't currently track the parent/previous folder that was opened it has no knowledge that it's entered into a recursive loop (as such a link causes).
I should imagine the fix would be a check so that :
code:

// this should already exist, in order to facilitate enqueing of an entire directory of files via a link to said directory
if(the shortcut is to a directory)
{
// this is the new check
if(directory being linked to != shortcut dir location)
{
// this should already exist in some form
EnqueueEntireDirectory(directory being linked to);
}
}

pushingsquares is offline   Reply With Quote
Old 19th January 2007, 12:20   #7
pushingsquares
Junior Member
 
Join Date: Jan 2007
Posts: 5
If it's already a known issue, I guess I'm not the only one silly enough to create a link in that manner

(Key point here being that I obviously didn't do it deliberately).
pushingsquares is offline   Reply With Quote
Old 19th January 2007, 12:23   #8
DrO
 
Join Date: Sep 2003
Posts: 27,873
yep, you're not the only one silly enough to do it though generally those who've experienced the issue have been found to have purposefully created the link for some obscure reason. as for the psuedo code, that's sort of how i was thinking but it's really down to how the current parser is implemented as to how easy making some control checks on things would be.

-daz
DrO is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Winamp > Winamp Bug Reports

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump