Edit attributes in an XML with nsisXML by Wizou

[pocz]

I can't figure it out.
I try to modify an XML, but I get lost when finding the issue why it's not working.
I have a file "foo.xml"

<global>
    <colors
      lava="orange"
      sky="blue"
    >
    </colors>
</global>

And I try to achieve this:

<global>
    <colors
      lava="orange"
      sky="cyan"
      earth="brown"
    >
    </colors>
</global>

Let's assume I am not sure if the attributes sky and earth exist in the file, before editing.
This is how my NSIS code looks like:

code:
nsisXML::create

nsisXML::load "foo.xml"

nsisXML::select "/global/colors"

nsisXML::setAttribute "sky" "cyan"

nsisXML::setAttribute "earth" "brown"

nsisXML::save

I haven't found any information in the documentation how to overwrite, add, or remove attributes with their values. Do I have to remove entire nodes, and append them again in the end?

[pocz]

I think nsisXML by Joel will be the easier solution to my problem.

code:
${nsisXML->removeAttr}

${nsisXML->SetElementAttr}

The simpliest way would be just to add the attributes, and hoping the old ones will be overwritten.
But knowing life, I probably have to check the attribute to see if it exists, then eventually remove it, and then add new attributes:
(Check if "sky" and "earth" exist, if they exist - remove them, create new attributes "sky" and "earth" with new values)

[Anders]

The Wizou plugin uses MSXML and MSDN says: "Sets or updates the supplied attribute node on this element"

[pocz]

I got it.
This in nsisXML by Wizou should be written in an other way, so it would work.

code:
nsisXML::create

nsisXML::load "foo.xml"

nsisXML::select "/global/colors"

nsisXML::setAttribute "sky" "cyan"

nsisXML::setAttribute "earth" "brown"

nsisXML::save

But it didn't work for me.
But this below did work, in nsisXML by Joel. Last time updated in 2009.

code:
${nsisXML->OpenXML} "foo.xml"

${nsisXML->SetElementAttr} "/global/colors" "sky" "cyan"

${nsisXML->SetElementAttr} "/global/colors" "earth" "brown"

${nsisXML->Release} "foo.xml"

I didn't have to remove anything. There are no clones of attributes, it just works, and looks simple.

If you have any ideas how the Wizous code should look like, please post your example.

[Anders]

Originally Posted by pocz

If you have any ideas how the Wizous code should look like, please post your example.

PHP Code:

FileOpen $0 "$temp\test.xml" w
FileWrite $0 '<?xml version="1.0" encoding="ISO-8859-1" ?><global><colors lava="orange" sky="blue"></colors></global>'
FileClose $0

nsisXML::create
DetailPrint $0,$1
nsisXML::load  "$temp\test.xml"
DetailPrint $0,$1
nsisXML::select "/global/colors"
nsisXML::setAttribute "sky" "cyan"
nsisXML::setAttribute "earth" "brown"
strcmp $0 0 +3
nsisXML::save "$temp\test.xml"
nsisXML::release $0

nsexec::ExecToLog 'cmd.exe /C type "$temp\test.xml"'
Pop $0

[pocz]

Ah, yes. I forgot to save the file properly.
nsisXML::save requires an argument.

The downside of the two nsisXML versions is,
that the structure is being rebuilt.
This is the result I was trying to achieve:

<global>
    <colors
      lava="orange"
      sky="cyan"
      earth="brown"
    >
    </colors>
</global>

But instead I get this:

<global>
    <colors lava="orange" sky="cyan" earth="brown">
    </colors>
</global>

The problem is, that the XML file has about a hundred of attributes in a single node, and this many attributes in a single line is a bit messy. Anyway, at least other programs can read all the values properly.

[pocz]

The problem is, that the XML file has about a hundred of attributes in a single node, and this many attributes in a single line is a bit messy.

Instead in an XML file, the dozens of attributes should have been stored in an INI file. It would be easier to read. ..

[Anders]

Originally Posted by pocz

The downside of the two nsisXML versions is,
that the structure is being rebuilt.

This will only save some of the whitespace but it is the best you are going to get with MSXML I'm guessing

PHP Code:

FileOpen $0 "$temp\test.xml" w
FileWrite $0 '<?xml version="1.0" encoding="ISO-8859-1" ?>$\r$\n$\r$\n<global><colors lava="orange" sky="blue">$\r$\n$\r$\n</colors>$\r$\n$\r$\n</global>'
FileClose $0

nsisXML::create
DetailPrint $0,$1
strcmp $0 0 +2
System::Call `$0->72(i-1)` ; put_preserveWhiteSpace
nsisXML::load  "$temp\test.xml"
nsisXML::select "/global/colors"
nsisXML::setAttribute "sky" "cyan"
nsisXML::setAttribute "earth" "brown"
strcmp $0 0 +3
nsisXML::save "$temp\test.xml"
nsisXML::release $0

nsexec::ExecToLog 'cmd.exe /C type "$temp\test.xml"'
Pop $0