Embeddedlist plugin needs refresh

[evilmephisto]

I've used the embeddedlists plugin which is great, but I faced a little bug(at least I think it is).

When I use the treeview with checkboxes and my tree is bigger then my dialog a part of the tree disappears. I can't get to it, I have to close/open one of the visible treenode(by clicking on the +). The gui is refreshed and a scrollbar becomes visible so I can get to the non visible tree nodes. So the problem is that it doesn't immidiately show the right scrollbar, so unexperienced user can never get to the lowest part of the tree.

[Afrow UK]

I'm planning on working on a unicode version of the plugin soon so I will see if I can fix this problem too.

Stu

[gringoloco023]

A unicode version will be really appreciated, as we came a long way with all the unicode plug-ins we did need.
This is basically the last one we need for our project !

Thanx, Mark

http://portableapps.com/node/21879

[Afrow UK]

I plan on having a look at this plugin soon.

Stu

[Afrow UK]

I was unable to reproduce the issue mentioned (tested on Windows XP and 7). Uploaded v1.3 with Unicode build.

Stu

[JohaViss]

I'm having a simular problem:

EmbeddeLists set up to show listitems with checkboxes.

1. I select a number of items
2. I go to the next screen.
3. I go back to the EmbeddeList screen.

All items are still there, but the checkboxes are gone.
I have to select each line to get them back.


Regards,
Johan

[Afrow UK]

Can you make a script that reproduces the issue please.

Stu

[beth62]

I am having the same problem with the EmbeddedLists plug-in that JohaViss describes above.

The first time the list is displayed the checkboxes display fine. If I hit Next and Back all the checkboxes have disappeared. I have to click on a list item and then click on another list item to have the first list item's checkbox repainted.

I am running XP SP3 with the "Windows XP style" Windows and buttons and the "Default (blue)" color scheme.

I tested with the examples that were provided with the EmbeddedLists plug-in, specifically the ListView_CheckBoxes.nsi and the ListView_MultiColumnCheckBoxes.nsi examples.

[beth62]

I tried all the included examples that have checkboxes, including both listviews and treeviews, and the checkboxes disappear in all of them when you hit Next and Back to return to the page.

[nickdollahz]

I've had that same issue when using UseCheckBitmap=<pathtocheckboxbmp>

I've also ran into several other issues.
ToggleNextButton staying disabled even if I check something
DisabledCheck=1 still allows you to check the checkbox with spacebar

Is there any plans to implement this plugin using nsdialogs?

I think I will just use that CommCtrl.nsh header that is floating around and a indented listview in the meantime.

[Nutzzz]

@nickdollahz : FYI, there's also InstallOptionsEx [which I can't link to because the board doesn't like the *s*E*x* part: http://nsis.sourceforge.net/InstallOption****plug-in]

[nickdollahz]

I did try the InstallOptionsEx early on when I ran into issues with UAC and SkinnedControls Plugin. There is a bug where it doesn't return the state of checked/unchecked items. It only returns whether or not the item is expanded 0 or 16. Unfortunately that plugin has been abandoned. Although I did dig into the C++ a bit and I actually did rig it to work but it caused issues else where. Probably some issue with how I fixed it. If I had a deeper understanding of how it all works then maybe I could have gotten a bit further.

There are actually quite a few plugins I would like to make changes to. Unfortunately I don't have much experience with C++ and it is a bit overwhelming. I was able to follow the logic somewhat but all the bits, pointer and memory location stuff is a bit over my head. I have been spoiled with other languages I guess.

Starting at around Line 5123 of InstallerOptions.cpp

// TreeView
//---------
case FIELD_TREEVIEW:
{
LPTSTR pszBuf2 = (LPTSTR)MALLOC(260*2+1);
LPTSTR pszBuf3 = (LPTSTR)MALLOC(260*2+1);

if(pField->nFlags & FLAG_CHECKBOXES)
{
bool bFinishing = FALSE;
TVITEM tvItem;
HTREEITEM hItem = TreeView_GetRoot(hwnd);
while(hItem)
{
tvItem.mask = TVIF_PARAM;
tvItem.hItem = hItem;
TreeView_GetItem(hwnd, &tvItem);

I believe I changed this to use tvItem.state and tvItem.stateMask.

There was also some other minor glitches as well. So I gave up probably better to start with a new plugin based off of nsdialogs at this point.

PS. If any one has any recommended resources that explains how all this stuff works. Feel free to send that my way. Until then I'm hoping some else saves the day.