ShnAmp 2.0.4 - Page 2

DJ Egg · 5th December 2006, 14:27

The playback issues seem to be fixed (no longer getting the 'stuck at 0:00' problem).

There's also no longer any crash/conflict when all of gen_undo (new test version), gen_nopro and in_shn (new build) are present.

Though there still seems to be some conflict between in_shn and gen_nunzio (aka: One For Nunz / plugins list generator), and possibly something to do with One For Nunz's pseudo columns feature (see screenshot: 1 = without gen_nunzio, 2 = with).

winamp caused an Access Violation (0xc0000005)
in module winamp.exe at 001b:00000000

I get this crash sometimes on playback of .shn files (but not every time), and it always occurs when a .shn is playing and trying to view: Prefs > Plugins > Input.

Other than that, I think we're almost there...

TonyRz · 5th December 2006, 16:28

Quote:

Originally posted by wstielau
I've fixed ShnAmp.
[p]
Attached is a fixed version if anyone would like to try it.

-Wayne

Wow. Just -- wow. Thanks. I thought this bug was a new nail in the coffin. I settled on Winamp a while back precisely because of the seamless compatibility with both FLAC and SHN, which I started getting a lot of. Of course, this compatibility was 100% due to the dedication of plugin developers like yourself.

(FTR, I wasn't having any new trouble with SHN format, but then I never opted for an "Essentials" install. But I dreaded adding yet another README in my winamp install directory about how plugin X doesn't work with program version Y and codec Z when the moon is full and you're wearing black shoes, etc....)

Things are seamless again. Thanks.

DrO · 5th December 2006, 21:20

the new in_shn now works with the official gen_undo and the now removed test build. also on a plus note it now works on my main install.

-daz

DrO · 5th December 2006, 22:12

looking into the issues Egg has reported, when in_shn's winampGetInModule2(..) is called more than once then it appears to cause the crash issue Egg was mentioning with the gen_nunzio plugin. the same issue is also exhibited when using my in_zip plugin (which wraps other input plugins allowing them to play files within archives). in the case of both plugins, winampGetInModule2(..) is called again after winamp has called it and any attempts at using/accessing the memory pointer returned by these calls will cause subsequent crashes which from experience with other input plugins i've worked with does not happen.

-daz

halbroome · 6th December 2006, 00:08

I'm glad people are finally recognizing this problem; I have a lot of legacy shns and flacs, and while I've had no problems with flac, my shn files definitely stopped this Winamp and the one before in its tracks (literally!).

I'm now using an earlier version that I found on an old backup disk (5.11, eek)and it works fine: as someone said earlier, no way I'm going back to reconvert shns to flac! Although I'd love to pay someone to do it for me 8').

wstielau's solution sounds worth trying -- fingers x'ed!

halbroome · 6th December 2006, 11:38

In a report back: wstielau's fix works!

I can now use the latest Winamp 8').

Thanks to all.

Ton80 · 6th December 2006, 16:07

There seems to be a problem with the seek function on shn type files using what Wayne posted for a fix up above.

If one moves the 'slider' to get to a certain desired spot in an shn file, 5.32 will not go there; instead it goes back where it was playing at. I can see the blue bar (on modern skin) going to where I selected but no joy.

Ok, default FLAC 5.32 playback works on moving the slider and so does CD playback. That's all the formats I can test right now.

halbroome: can u confirm same results?

wstielau · 6th December 2006, 18:50

Are you sure the shn file is seekable? Not all shorten files are. Check file info and see if it indicates if it is seekable.

-Wayne

Quote:

Originally posted by Ton80
There seems to be a problem with the seek function on shn type files using what Wayne posted for a fix up above.

If one moves the 'slider' to get to a certain desired spot in an shn file, 5.32 will not go there; instead it goes back where it was playing at. I can see the blue bar (on modern skin) going to where I selected but no joy.

Ok, default FLAC 5.32 playback works on moving the slider and so does CD playback. That's all the formats I can test right now.

halbroome: can u confirm same results?

Ton80 · 6th December 2006, 18:52

Quote:

Originally posted by wstielau
Are you sure the shn file is seekable? Not all shorten files are. Check file info and see if it indicates if it is seekable.

-Wayne

ok just checked mp3 and it works.

To Wayne how the heck do I check shn on what you just said?

Hmmm tried another set of shn and the slider works so wow uh ok Wayne was right. Wow. Forgive me then.

Uh how can one tell which would be 'bad' and not 'bad'?

wstielau · 6th December 2006, 18:57

Right-click the file in the playlist and select file info.

Quote:

Originally posted by Ton80
ok just checked mp3 and it works.

To Wayne how the heck do I check shn on what you just said?

Ton80 · 6th December 2006, 19:00

ah Now I see it thanks Wayne.

Never thought of that; which might bring this up again from another noob. Is it related to an older shn codec?

We might need to advise our hubbers on older shn/winamp 5.32 behavior but too much work/material to update to latest shn.

wstielau · 6th December 2006, 19:04

The original Shorten implementation did not support seeking. I extended the original spec to support seeking (Shorten V3) shortly after I wrote the first version of ShnAmp.

Quote:

Originally posted by Ton80
ah Now I see it thanks Wayne.

Never thought of that; which might bring this up again from another noob. Is it related to an older shn codec?

Ton80 · 6th December 2006, 19:06

Quote:

Originally posted by wstielau
The original Shorten implementation did not support seeking. I extended the original spec to support seeking (Shorten V3) shortly after I wrote the first version of ShnAmp.

Oh ok hmmm some peeps snuck in quickly in between releases.

Well sorry for 'crying Wolf' falsely wasn't intentional in any malicious sense. I was just report what I had encountered on one set of shn files. Again please forgive me.

loganmr · 12th December 2006, 19:16

Ah! Thanks so much for fixing the shn won't play problem! I thought I was the only one having this error. After installing the new file, everything works fine. Thanks so much!

wstielau · 16th December 2006, 21:58

Quote:

Originally posted by DJ Egg
Though there still seems to be some conflict between in_shn and gen_nunzio (aka: One For Nunz / plugins list generator), and possibly something to do with One For Nunz's pseudo columns feature (see screenshot: 1 = without gen_nunzio, 2 = with).

winamp caused an Access Violation (0xc0000005)
in module winamp.exe at 001b:00000000

I get this crash sometimes on playback of .shn files (but not every time), and it always occurs when a .shn is playing and trying to view: Prefs > Plugins > Input.

Other than that, I think we're almost there...

I've also resolved this issue. ShnAmp was reinitializing the In_Module structure that is returned by winampGetInModule2() when it was called the second time. This would cause the outMod member to be set to NULL, crashing the decode thread.

Attached is ShnAmp 2.04 containing the fix.

DrO · 16th December 2006, 22:21

yup, all is working fine now with the 2.04 build

-daz

jph6t · 1st February 2007, 23:21

Quote:

Originally posted by wstielau
Attached is ShnAmp 2.04 containing the fix.

wstielau, what is the primary source for the latest version of ShnAmp?

I have always have gone to etree.org when I needed to download ShnAmp.
But I see that etree still has v2.02. Is this just an oversight? Or is there a better source than etree? Or third option, are you still looking at v2.04 as I beta?

Just wanted to make sure our friendly bootleggers have the latest plugin too.

jph6t · 1st February 2007, 23:32

Quote:

Originally posted by DJ Egg
Yeah, I unchecked the gapless output plugin in the ShnAmp installer.

I reckon that the bundled gapless output plugin is pretty old and probably not too compatible. Besides, Winamp's DirectSound Output does gapless anyway (out_ds > config > buffering tab > buffer ahead on track change // other tab > remove silence). But there's also a possibility that the gapless settings (whether via out_ds or 3rd-party output plugin) are causing the "won't play" issue.

DJ Egg, what was the final decision on this? I recently got a new machine and had to re-install Winamp and my plugins. Is the fact I checked the gapless output option going to mess anything up for me?

DJ Egg · 2nd February 2007, 07:34

No. Just use DirectSound Output in Winamp.
And use the Nullsoft FLAC Decoder which comes with Winamp 5.3x for Flac playback, and use the latest in_shn ShnAmp v2.04 (as attached to wstielau's post above) for .shn playback.

Ton80 · 16th February 2007, 13:18

So far the 2.04 works also with winamp 5.33, wstielau.
Thx again for your time.

Ton80 · 24th April 2007, 12:11

The shn 204 zip posted above also works with winamp 5.34. But shnamp202.exe does not.

DrO · 24th April 2007, 13:09

obviously 2.02 will not work with 5.34 since the plugin was flawed just that until the changes were made to the winamp core for plugin loading that it never showed up. shouldn't be using 2.02 now anyway, heh

-daz

jph6t · 24th April 2007, 18:44

Quote:

Originally posted by DrO
shouldn't be using 2.02 now anyway

As DrO pointed out ... ShnAmp v2.04 is the latest.
etree.org needs to make a v2.04 exe and update thier site.

Ary · 6th June 2007, 11:59

Thanks wstielau for fix.

beeerlover · 12th June 2007, 16:53

Quote:

Originally posted by wstielau
I've also resolved this issue. ShnAmp was reinitializing the In_Module structure that is returned by winampGetInModule2() when it was called the second time. This would cause the outMod member to be set to NULL, crashing the decode thread.

Attached is ShnAmp 2.04 containing the fix.

I want to say thanks. This fixed my problems perfectly.

http://forums.winamp.com/showthread....34#post2083434

Next, lol, care to tackle making shnamp display the folder like flac can in the ATF? This would allow all my previous and upcoming concerts to display correctly for the broadcasting, if it can be done.

Thanks, again!

Jimpin · 19th June 2007, 00:32

Thanks for the fix.
Best regards...

jjordan1520 · 22nd June 2007, 17:25

how do i apply the shnAmp v2.04 fix to my plugins?

DJ Egg · 22nd June 2007, 17:37

Download the zip attachment
http://forums.winamp.com/attachment.php?postid=2083434

With Winamp closed, unzip in_shn.dll to the Winamp\Plugins folder.

jjordan1520 · 22nd June 2007, 18:41

Got it. Thanks.

5th December 2006, 21:20	#43
DrO Join Date: Sep 2003 Posts: 27,873	the new in_shn now works with the official gen_undo and the now removed test build. also on a plus note it now works on my main install. -daz WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

5th December 2006, 22:12	#44
DrO Join Date: Sep 2003 Posts: 27,873	looking into the issues Egg has reported, when in_shn's winampGetInModule2(..) is called more than once then it appears to cause the crash issue Egg was mentioning with the gen_nunzio plugin. the same issue is also exhibited when using my in_zip plugin (which wraps other input plugins allowing them to play files within archives). in the case of both plugins, winampGetInModule2(..) is called again after winamp has called it and any attempts at using/accessing the memory pointer returned by these calls will cause subsequent crashes which from experience with other input plugins i've worked with does not happen. -daz WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

6th December 2006, 16:07	#47
Ton80 Junior Member Join Date: Dec 2006 Location: Chattanooga, TN. USA Posts: 11	There seems to be a problem with the seek function on shn type files using what Wayne posted for a fix up above. If one moves the 'slider' to get to a certain desired spot in an shn file, 5.32 will not go there; instead it goes back where it was playing at. I can see the blue bar (on modern skin) going to where I selected but no joy. Ok, default FLAC 5.32 playback works on moving the slider and so does CD playback. That's all the formats I can test right now. halbroome: can u confirm same results? Last edited by Ton80; 6th December 2006 at 17:07.

16th December 2006, 22:21	#56
DrO Join Date: Sep 2003 Posts: 27,873	yup, all is working fine now with the 2.04 build -daz WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

2nd February 2007, 07:34	#59
DJ Egg Techorator Winamp & Shoutcast Team Join Date: Jun 2000 Posts: 36,136	No. Just use DirectSound Output in Winamp. And use the Nullsoft FLAC Decoder which comes with Winamp 5.3x for Flac playback, and use the latest in_shn ShnAmp v2.04 (as attached to wstielau's post above) for .shn playback. Playlist \| Twitter \| Albums

6th December 2006, 00:08	#45
halbroome Junior Member Join Date: Dec 2006 Posts: 2	I'm glad people are finally recognizing this problem; I have a lot of legacy shns and flacs, and while I've had no problems with flac, my shn files definitely stopped this Winamp and the one before in its tracks (literally!). I'm now using an earlier version that I found on an old backup disk (5.11, eek)and it works fine: as someone said earlier, no way I'm going back to reconvert shns to flac! Although I'd love to pay someone to do it for me 8'). wstielau's solution sounds worth trying -- fingers x'ed!

6th December 2006, 11:38	#46
halbroome Junior Member Join Date: Dec 2006 Posts: 2	In a report back: wstielau's fix works! I can now use the latest Winamp 8'). Thanks to all.

6th December 2006, 19:00	#51
Ton80 Junior Member Join Date: Dec 2006 Location: Chattanooga, TN. USA Posts: 11	ah Now I see it thanks Wayne. Never thought of that; which might bring this up again from another noob. Is it related to an older shn codec? We might need to advise our hubbers on older shn/winamp 5.32 behavior but too much work/material to update to latest shn.

12th December 2006, 19:16	#54
loganmr Junior Member Join Date: Dec 2006 Posts: 1	Ah! Thanks so much for fixing the shn won't play problem! I thought I was the only one having this error. After installing the new file, everything works fine. Thanks so much!

16th February 2007, 13:18	#60
Ton80 Junior Member Join Date: Dec 2006 Location: Chattanooga, TN. USA Posts: 11	So far the 2.04 works also with winamp 5.33, wstielau. Thx again for your time.

24th April 2007, 12:11	#61
Ton80 Junior Member Join Date: Dec 2006 Location: Chattanooga, TN. USA Posts: 11	The shn 204 zip posted above also works with winamp 5.34. But shnamp202.exe does not.

24th April 2007, 13:09	#62
DrO Join Date: Sep 2003 Posts: 27,873	obviously 2.02 will not work with 5.34 since the plugin was flawed just that until the changes were made to the winamp core for plugin loading that it never showed up. shouldn't be using 2.02 now anyway, heh -daz WACUP Project <‖> "Winamp Ramblings" - Indie Winamp Dev Blog

6th June 2007, 11:59	#64
Ary Banned Join Date: May 2007 Posts: 54	Thanks wstielau for fix.

19th June 2007, 00:32	#66
Jimpin Banned Join Date: Jun 2007 Location: Iran Posts: 7	Thanks for the fix. Best regards...

22nd June 2007, 17:25	#67
jjordan1520 Junior Member Join Date: Jun 2007 Posts: 2	applying v2.04 how do i apply the shnAmp v2.04 fix to my plugins?

22nd June 2007, 17:37	#68
DJ Egg Techorator Winamp & Shoutcast Team Join Date: Jun 2000 Posts: 36,136	Download the zip attachment http://forums.winamp.com/attachment.php?postid=2083434 With Winamp closed, unzip in_shn.dll to the Winamp\Plugins folder. Playlist \| Twitter \| Albums

22nd June 2007, 18:41	#69
jjordan1520 Junior Member Join Date: Jun 2007 Posts: 2	Got it. Thanks.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode