Probe for lost songs causes crash

[fatcerberus1]

I recently tried to run a "probe for lost songs" on my shuffle, since the DB seems to have been inexplicably wiped out. Unfortunately, probe for lost songs crashes Winamp every time for me.

If it helps, I've attached a debuglog from immediately after the crash.

[abu]

Could not reproduce this. Try the debugger, please... Might be some special track that causes problems...???

[fatcerberus1]

It's crashing in itemlist.cpp, specifically in C_ItemList::Add. The reason appears to be an invalid this pointer (at the time of the crash, this = 0x00000034)

I'll have to investigate this some more...

Edit: If it helps, it only seems to crash if there actually are lost songs. I was only able to reproduce it by deleting all the songs off the iPod, transferring some new songs, then doing Safely Remove on the iPod without ejecting it.

[fatcerberus1]

Found it.

shuffles don't support playlists. So when ml_iPod tries to create a "Lost & Found" playlist to contain the missing tracks, add_new_playlist returns NULL. Therefore, pl==NULL, so when you try to call Add on it to add a track, ml_iPod crashes.

Should be simple enough to fix myself...

Edit: Fixed.

[abu]

Cool. But I think I'll change that later, to allow this special playlist even on a shuffle. It's very handy.

[abu]

Ok, this is fixed now with 3.00p05. Thanks for finding the cause.