volumebyregion & volumeknob drop volume

[ariszlo]

The attached skin calls volumebyregion.maki in main mode and volumeknob.maki in shade mode. When I switch to this skin, the volume drops. Also, if I start Winamp with this skin, the volume starts low.

What causes this drop and how can it be fixed?

[PeterK.]

Originally Posted by ariszlo

...When I switch to this skin, the volume drops. Also, if I start Winamp with this skin, the volume starts low...

I cannot reproduce your issues - volume is fine while switching to shade mode and back or starting with this skin, which, by the way, would look really great on a high-res display if it was twice as big.

[ariszlo]

Originally Posted by PeterK.

I cannot reproduce your issues - volume is fine while switching to shade mode and back or starting with this skin...

Then you probably keep the volume low. Try this: raise the volume up to 50% in Quinto then switch to Venom. The volume should go down to about 25%.

Originally Posted by PeterK.

...which, by the way, would look really great on a high-res display if it was twice as big.

Yes, I know. All old skins are small. But some are even smaller.

[PeterK.]

Quinto's volume at 100 % and switched to Venom. Also 100 %.

[ariszlo]

Thanks for testing it. Then it is probably some weird, hardware related issue.

[Victhor]

I'm seeing this issue too, is not just you Ariszlo.

[ariszlo]

Thanks, Victhor!

Meanwhile, I have found the culprit. If I comment this out in player-normal.xml then Venom will properly keep the volume level:

PHP Code:

<script id="electricity" file="scripts/electricity.maki"/> 


So editing electricity.m might fix the issue.

[ariszlo]

This is what electricity.maki does:

If the boost button is pressed then the volume is raised to 255 (= 100%).
If it is unpressed then it is lowered to 50 (= 20%).

How do you modifiy the script to

1. not change the volume level if switching to Venom from another skin,
2. remember what the volume level was before toggling boost on,
3. restore the original volume level when toggling boost off?

In other words, how do you make it true what the skin's author says?

Originally Posted by QuadHeliX

The skin just remembers the volume where it was left at before boost.

[ariszlo]

Getting there. Below is how I edited electricity.m. Now, if I toggle boost on then volume goes up to 100% as expected. If I toggle it off then it returns to the original level. So far so good. If I switch skins or quit Winamp while boost is off then volume is preserved fine. However, if I switch skins or quit Winamp while boost is on then the boost level (= 100%) is saved, not the original level.

What do I need to add to the script to toggle boost of before switching skins or quitting Winamp?

PHP Code:

#include "../../../lib/std.mi"

Global ToggleButton mytoggle, boost;
Global AnimatedLayer animlayer;
Global Boolean elecstatus, booststatus;
Global Group stdgrp;
Global Int oldvol; // added
Global Int olpreamp; // added

System.onScriptLoaded()
{
    stdgrp=getScriptGroup();

    oldvol = system.getVolume(); // added
    olpreamp = system.getEqPreamp(); // added

    mytoggle=stdgrp.findObject("mytoggle");
    boost=stdgrp.findObject("boost");
    animlayer=stdgrp.findObject("animatedlayer");

    booststatus = getPrivateInt("Venom","toggle_boost",0);
    boost.setActivated(booststatus);
    boost.onToggle(booststatus);

    elecstatus = getPrivateInt("Venom","toggle_electricity",0);
    mytoggle.setActivated(elecstatus);
    mytoggle.onToggle(elecstatus);
}

mytoggle.onToggle(Boolean t)
{
    setPrivateInt("Venom","toggle_electricity",t);

    if(t){
        animlayer.play();
    }else{
        animlayer.stop();
        animlayer.gotoFrame(0);
    }
}

boost.onToggle(Boolean t)
{
    setPrivateInt("Venom","toggle_boost",t);

    if(t){
        //setPrivateInt("Venom","old_volume",getVolume());
        //setPrivateInt("Venom","old_preamp",getEqPreamp());
        setVolume(255);
        setEqPreamp(127);
        animlayer.play();
    }else{
        if(!mytoggle.getActivated()){
            animlayer.stop();
            animlayer.gotoFrame(0);
        }
        //setVolume(getPrivateInt("Venom","old_volume",50));
        //setEqPreamp(getPrivateInt("Venom","old_preamp",0));        
        system.setVolume(oldvol);
        system.setEqPreamp(olpreamp);
    }
} 


[ariszlo]

Rereading electricity.m, I realized that the script does what is written in it so the volume drop is not a bug but a feature.

[ariszlo]

Originally Posted by ariszlo

What do I need to add to the script to toggle boost of before switching skins or quitting Winamp?

Even though I am not going to fix what is not broken and leave electricity.m as it is, I am really curious to know if it is possible to automatically toggle off a button when closing Winamp or switching to another skin.

[garetjax]

save it to the global - and re-use on maki as a base set for the vol and setting.