in_flac inconsistenies

thinktink · 14th May 2014, 01:57

This is not really so much a bug as it is a nuisance or inconsistency with in_flac and the other input plugins. I've noticed that the built-in EQ shows the changes made by DSP plugins when playing files decoded by most other input plugins but does not when playing files with in_flac. It appears that in_flac is first sending samples to the SAAddPCMData and similar functions before sending them to the DSP instead of the other way 'round like in in_mp3 and and in_wav

Aminifu · 14th May 2014, 03:17

Thank you for your post. I've been trying to figure out the processing train (without the benefit of the tools you have available) and it did seem to change depending on the file format. This has lead me to stop using Winamp's EQ in most cases. Usually when I need equalizing, I use the EQ provided with my sound card. It's only a 7-band EQ, but it's effects are added after all the Winamp + my 3rd party DSP plug-in (Stereo Tool without it's EQ function) processing.

MrSinatra · 14th May 2014, 08:54

Quote:

Originally Posted by thinktink

This is not really so much a bug as it is a nuisance or inconsistency with in_flac and the other input plugins. I've noticed that the built-in EQ shows the changes made by DSP plugins when playing files decoded by most other input plugins but does not when playing files with in_flac. It appears that in_flac is first sending samples to the SAAddPCMData and similar functions before sending them to the DSP instead of the other way 'round like in in_mp3 and and in_wav

that sounds like a bug to me. is it also true of ALAC files?

DrO · 14th May 2014, 12:54

what's being mentioned only relates to visual elements and is not related to actual DSP processing which is done via a different code path (as can be confirmed by messing around with the preamp level on the EQ which is the easiest way i believe to see the effect when comparing FLAC vs MP3 versions of the same file).

in_flac itself doesn't call the methods mentioned and instead uses SAGetMode(..) and SAAdd(..) which a number of other input plug-ins also use (but it depends on the format / mode as to what will or will not be used - often determined by how the audio is obtained).

whether it's a bug or not is debatable, but for the time being i don't intend to make any changes other than logging this as something to check if i get really bored.

14th May 2014, 01:57	#1
thinktink Forum King Join Date: May 2009 Location: On the streets of Kings County, CA. Posts: 3,023	in_flac inconsistenies This is not really so much a bug as it is a nuisance or inconsistency with in_flac and the other input plugins. I've noticed that the built-in EQ shows the changes made by DSP plugins when playing files decoded by most other input plugins but does not when playing files with in_flac. It appears that in_flac is first sending samples to the SAAddPCMData and similar functions before sending them to the DSP instead of the other way 'round like in in_mp3 and and in_wav \| Opus Audio Codec plugins 2.0 \| Embedded Album Art \| DiskWrite \| \| Save your playlist first! \| Live voice-over \| X-Fade 2.2 \| \| More of my stuff... \|

14th May 2014, 03:17	#2
Aminifu Forum King Join Date: Aug 2011 Location: Phoenix, AZ Posts: 4,772	Thank you for your post. I've been trying to figure out the processing train (without the benefit of the tools you have available) and it did seem to change depending on the file format. This has lead me to stop using Winamp's EQ in most cases. Usually when I need equalizing, I use the EQ provided with my sound card. It's only a 7-band EQ, but it's effects are added after all the Winamp + my 3rd party DSP plug-in (Stereo Tool without it's EQ function) processing. Winamp Pro v5.666.3516 fully-patched - Quinto Black CT v3.1 skin Windows 10 Home 64-bit v20H2 desktop - Logitech Z906 5.1 speaker system

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search
Display Modes
Switch to Linear Mode Hybrid Mode Switch to Threaded Mode

14th May 2014, 12:54	#4
DrO Join Date: Sep 2003 Posts: 27,873	what's being mentioned only relates to visual elements and is not related to actual DSP processing which is done via a different code path (as can be confirmed by messing around with the preamp level on the EQ which is the easiest way i believe to see the effect when comparing FLAC vs MP3 versions of the same file). in_flac itself doesn't call the methods mentioned and instead uses SAGetMode(..) and SAAdd(..) which a number of other input plug-ins also use (but it depends on the format / mode as to what will or will not be used - often determined by how the audio is obtained). whether it's a bug or not is debatable, but for the time being i don't intend to make any changes other than logging this as something to check if i get really bored.