Old 31st March 2005, 08:20   #1
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
Banner with CANCEL button

There is have one http://nsis.sourceforge.net/archive/...instances=0,32

But this "NxS MSI LoaderDlg" plugin are crashes then it called from Custom Page "Function LeaveCustom" (and MSI Banner too).

I trying contact with saivert (author) with no luck.

Can anybody fix this problem (i'm have poor knowledge of C++)?
Instructor is offline   Reply With Quote
Old 31st March 2005, 10:06   #2
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
May be attached version.. I had not script to test cross-dialog situation.
Attached Files
File Type: zip nxsmsiloaderdlg.zip (15.7 KB, 699 views)
Takhir is offline   Reply With Quote
Old 31st March 2005, 15:03   #3
Joel
Debian user
(Forum King)
 
Joel's Avatar
 
Join Date: Jan 2003
Location: Arch land
Posts: 4,918
Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you


* PC: Intel Core 2 DUO E6550 @ 2.33 GHz with 2 GB RAM: Archlinux-i686 with MATE.
* Laptop: Intel Core 2 DUO T6600 @ 2.20 GHz with 4 GB RAM: Archlinux-x86-64 with MATE.

Joel is offline   Reply With Quote
Old 31st March 2005, 15:43   #4
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
Thanks, Takhir

Quote:
Those "crashes" are because you need to handle the banners after the page is gone... we can't do everything for you
Before Takhir change the code setup crashes immediately after "NxSMSILoaderDlg::Show /NOUNLOAD ..."

Another problem:
"NxSMSILoaderDlg::update /NOUNLOAD ..." is clear the stack I use it in the callback function (of course setup quit from function after it)
Instructor is offline   Reply With Quote
Old 31st March 2005, 16:32   #5
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
New /end parameter - see attached script.
I also increased height of the static control displaying cuurent path (3 lines max now).
Attached Files
File Type: zip nxs.zip (3.2 KB, 643 views)
Takhir is offline   Reply With Quote
Old 31st March 2005, 17:58   #6
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
WOW, Takhir one more thing. CANCEL button is allways disabled (trying: /can 0 and /can 1).

EDIT:
And /top parameter also use default value

Last edited by Instructor; 31st March 2005 at 18:17.
Instructor is offline   Reply With Quote
Old 31st March 2005, 20:58   #7
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
90% of new code
Attached Files
File Type: zip nxs.zip (3.1 KB, 657 views)
Takhir is offline   Reply With Quote
Old 31st March 2005, 22:43   #8
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
Takhir, my russian amazing friend, thank you.

P.S.
Necessarily publish it (you fix all problems and reduced the size of packed plugin by 85 %)
Instructor is offline   Reply With Quote
Old 1st April 2005, 10:23   #9
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
Sources and binaries. Banner path text flicking and foreground window position improved, Task bar button issue fixed, dll and entry points renamed (NxSMSILoaderDlg.dll->nxs.dll, show->Show... - see Readme), file size 5.5 kB now (2.3 kB in zip), 2 samples included - original saivert' and sent by Instructor. "Change history" header added to C file.

Saivert, please don't kill me
Attached Files
File Type: zip nxs.zip (18.3 KB, 644 views)
Takhir is offline   Reply With Quote
Old 1st April 2005, 13:02   #10
DrO
 
Join Date: Sep 2003
Posts: 27,873
Quote:
Originally posted by Takhir
Saivert, please don't kill me
that'd be an interesting fight to watch

-daz
DrO is offline   Reply With Quote
Old 1st April 2005, 14:13   #11
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
Then I run example.nsi in WinMe (in WinXP all fine) it shows:
Attached Images
File Type: jpg nxs.jpg (15.9 KB, 712 views)
Instructor is offline   Reply With Quote
Old 1st April 2005, 16:51   #12
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
I see, 98/Me not updates frame size on window style changes (related to hidden or visible Task bar button /h option), so banner will have on 98/Me toolwindow style - decreased caption height, regular font in the /h 1 mode (no task bar button), bold otherwise (system defines this). I know about hidden parent window and appwindow style tricks, but I don't like this way. New version attached.
Attached Files
File Type: zip nxs.zip (18.4 KB, 534 views)
Takhir is offline   Reply With Quote
Old 1st April 2005, 19:52   #13
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
I made some changes in readme and examples. If something will seem to you interesting.
Attached Files
File Type: zip doc.zip (11.2 KB, 595 views)
Instructor is offline   Reply With Quote
Old 2nd April 2005, 15:58   #14
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
Thanks, Instructor!
I added your files to package, but I had to do some changes in example.nsi - like saivert wrote, first installer's page stays minimized without explicit ShowWindow in the .onGuiInit if banner was shown in .onInit function. The same happened on my XP with "100% done" message box after banner destroyed in .onInit, so I commented this line in your script.
Attached Files
File Type: zip nxs.zip (18.8 KB, 987 views)
Takhir is offline   Reply With Quote
Old 2nd April 2005, 17:37   #15
Instructor
Major Dude
 
Join Date: Jul 2004
Posts: 671
I'm grateful to you (and to saivert too).
Instructor is offline   Reply With Quote
Old 3rd May 2005, 07:06   #16
saivert
Banned
 
saivert's Avatar
 
Join Date: Jan 2001
Location: Norway
Posts: 927
Hi! This is great work. Takhir and Instructor, thanks for fixing my code (that's why I included the source code). I tried to fix MSIBanner's code, but since I based my code on the MSIBanner project think a lot of the bugs from MSIBanner replicated in my plug-in. I should have started from scratch. But I guess you (Takhir) have reworked the code now, so now most of it is new code (hopefully).

But my idea with a Cancel button was great, right?
And why did you rename the plug-in to nxs.dll. NxS is just my prefix. My real name is Nicolai Syvertsen, so I just made that into NxS (putting in an x just cos' it's cool).
I don't think you make the installer that much smaller by keeping filename sizes short. Isn't the datablock compressed anyway??

But again (sorry for caps lock): GREAT WORK!
saivert is offline   Reply With Quote
Old 31st May 2011, 12:03   #17
SJSJ
Junior Member
 
Join Date: May 2011
Posts: 25
Unicode version?

Hi,

The Nxs banner plugin was exactly what I was looking for. It works great.
Do you have a Unicode version, Takhir?

I tried changing the code by following instructions from http://forums.winamp.com/showpost.ph...95&postcount=6 but did not succeed.
The pop up comes but the marquee does not.

Please let me know if somebody has tried the Unicode version.

Thanks!!
SJSJ is offline   Reply With Quote
Old 31st May 2011, 15:27   #18
MSG
Major Dude
 
Join Date: Oct 2006
Posts: 1,892
Have you tried using it with the CallAnsiPlugin plugin?
MSG is offline   Reply With Quote
Old 1st June 2011, 04:38   #19
SJSJ
Junior Member
 
Join Date: May 2011
Posts: 25
Not yet!
Thanks, MSG, for the suggestion.
Looks promising.
I shall try and post the results!
SJSJ is offline   Reply With Quote
Old 1st June 2011, 05:36   #20
SJSJ
Junior Member
 
Join Date: May 2011
Posts: 25
MSG, it worked :-D
That is a great plugin.
Thank you!
SJSJ is offline   Reply With Quote
Old 4th June 2011, 10:02   #21
Takhir
Major Dude
 
Join Date: Feb 2004
Location: Moscow, Russia
Posts: 1,222
Excuse for a time delay, Unicode version uploaded http://nsis.sourceforge.net/File:Nxs.zip
Takhir is offline   Reply With Quote
Old 6th June 2011, 07:26   #22
SJSJ
Junior Member
 
Join Date: May 2011
Posts: 25
That is great!
I shall check that too.
Thanks, Takhir.
SJSJ is offline   Reply With Quote
Old 6th July 2011, 11:30   #23
Yathosho
Forum King
 
Yathosho's Avatar
 
Join Date: Jan 2002
Location: AT-DE
Posts: 3,368
i don't care, but for the record: the marquee banner does not work on windows 98
Yathosho is offline   Reply With Quote
Reply
Go Back   Winamp & Shoutcast Forums > Developer Center > NSIS Discussion

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump