http + ftp download plug-in

[Vytautas]

OK, Found another issue, when authentication is used even if the correct info is provided it displays canceled first time, then when retrying to authenticate it works OK.

here is the sample code used

code:
downloadcrmsi:

  	StrCpy $CR_Install "$INSTDIR\CRRedist2005_x86.msi"

	inetc::get /NOCANCEL "https://xyz.com/CRRedist2005_x86.msi" "$INSTDIR\CRRedist2005_x86.msi"

    Pop $1

	Dumpstate::debug

	${If} $1 == "OK"

	  Goto installcr

	${Else}

	  MessageBox MB_RETRYCANCEL "Download Failed!" IDRETRY downloadcrmsi

	  Abort "Crystal Reports Runtime 10.2 Download Failed"

	${EndIf}

as can be seen even when correct login is specified i get a download failed box come up, when retry is pressed it connect straight away without asking for authentication

[jiake]

If it better that if the plugins may support multilanguage. I'm Chinese, some plugins provide a header file to define multilanguge, some not. If all plugins support multilanguage, that is better.

[Takhir]

Vytautas: thanks again! I hope this is fixed now..
jiake: yes, this would be better, but for now you can use /TRANSLATE option for /POPUP and NSISdl mode, /BANNER mode also has text parameters. Use LangString if you want to support few langs in your installer.

[Vytautas]

Thank you Takhir, that indeed seems to have fixed this problem.

[{_trueparuex^}]

Currently all 3xx errors are treated as redirection. You should add and exception for "304 not modified" status. Users may send "If-None-Match" or "If-Modified-Since" header to check if the file has changed on the server.

[pengyou]

I use Inetc's /RESUME option to display a message when Inetc is unable to download a file. This is useful for users who are still using dial-up connections.

This /RESUME feature no longer works properly. If there is no connection to the internet the plugin now creates an empty file and does not return the "SendRequest Error". My installer then tries to use the empty file and fails because the file is zero bytes long.

The Inetc plugin dated 1 April 2008 is OK - if there is no connection to the internet it returns the "SendRequest Error".

The Inetc plugins dated 30 April, 4 May and 20 May 2008 do not return the "SendRequest Error" if the internet connection is down.

[Takhir]

Not reproduces. I unplugged LAN cable (ethernet) and resume popup appears as expected. Exit status is SendRequestError.

code:
Inetc::get /RESUME "" "http://kolobok/sfu_3.exe" "$EXEDIR\sfu.exe"

"$EXEDIR\u.jpg"

Pop $0

MessageBox MB_OK "Download Status: $0"

May 20 version.

[pengyou]

The new Inetc plugin, dated 21 May 2008, fixes the problem so my installer now works properly.

Thank you for fixing this problem so quickly.

[daisywheel]

Hi,

Take a look at code below.

code:


Name "test"

OutFile "test.exe"



;SilentInstall silent



!define UpdateConfigFile "update.ini"

!define UpdateURL "http://www.daisywheel.kiev.ua" ;





;---------------------------------------------------------------------------------

; Sections

;---------------------------------------------------------------------------------

Section



loop:



	MessageBox MB_OK "hi!"

	

    InetLoad::load /SILENT "${UpdateURL}/${UpdateConfigFile}" "$TEMP\${UpdateConfigFile}" 

    ;InetLoad::load "${UpdateURL}/${UpdateConfigFile}" "$TEMP\${UpdateConfigFile}" 

    Pop $0

    MessageBox MB_OK $0

    

    StrCmp $0 "OK" 0 loop

	



SectionEnd 

When I add /SILENT to InetLoad::load call I get not "OK" response but "connecting" and file is not loaded.

Is it a bug or do I misinterpret something?

tnx,
Roman

[Takhir]

Please not /silent option description:
[/SILENT TEXT2DISPLAY]
SILENT
Key hides plug-in' output (both popup dialog and embedded progress bar). Sets TEXT2DISPLAY to 1006 control, if /silent "" - displays "InetLoad plug-in" default. Not required if 'SilentInstall silent' mode was defined in script (NSIS 2.03 option).

[********]

Very nice POPUP dialog. I wonder if it is possible to embed it somehow into main window?

[Takhir]

This is NOT implemented in current version. But if you know C, you can change parent window for POPUP here

code:
if((hDlg = CreateDialog(g_hInstance,

MAKEINTRESOURCE(szBanner ? IDD_DIALOG2 : (popup ? IDD_DIALOG1 : IDD_DIALOG3)),

(popup ? hwndParent : childwnd), dlgProc)) != NULL)

to

code:
if((hDlg = CreateDialog(g_hInstance,

MAKEINTRESOURCE(szBanner ? IDD_DIALOG2 : (popup ? IDD_DIALOG1 : IDD_DIALOG3)),

(szBanner ? hwndParent : childwnd), dlgProc)) != NULL)

and to change POPUP dialog properties to 'child' and 'no frame'. May be some other small changes require. After this plug-in shuld work with embedded POPUP window.

[********]

Thanks, but I'll better stick to official version. =)

This /POPUP option caused some unpleasant moments with upgrading an old installer. New obligatory /POPUP parameter caused downloads to fail with "URL Parts Error" after the upgrade. New parameter was omitted in old installers and new inetc still consumed the following option as an argument making the command wrong.

Now if /POPUP "" is specified, the URL field in popup window is empty while it should be not according to docs. I tested this on bundled Example.nsi Can anybody confirm?

BTW, it would be nice to have this URL clickable or copyable for diagnosis of download problems.

P.S. To track the issue the whole inetc history was recreated at Launchpad. https://code.launchpad.net/~techtonik/+junk/inetc

[Takhir]

Thanks, ********, I updated inetc.zip, now it displays URL if "". This was lost at least half of year ago
To make URL copyable I should change control type from 'static' to 'edit'. To keep GUI integrity this should be done for all controls on this dialog, tested... New option required for 'clickable' URL.. So.. good idea, may be with next big changes
I agree, parameters changes (/POPUP with text value) is not good for support, but this happen sometimes...

[xbarns]

I am trying to get your example_unicode.nsi to work with the NSIS 2.38.-1 Unicode, but it does not work

I am using your original example_unicode.nsi from the latest .zip.

The details window says

Download Status: 剕⁌慐瑲⁳牅潲r, 剕⁌慐瑲⁳牅潲r, 剕⁌慐瑲⁳牅潲r
Completed

[vbplayr2000]

I'm close to getting this implemented, but I keep running into a roadblock at the point at which I need to download the file and write it to the TEMP directory. The script successfully creates the 'receiving' file (jre-6u7-win...exe) that the stream is to be written to, but I am lost as to what happens after that.

The error message I see is "Download failed: OK"

Here is the snippet of code where it fails:

<code> DownloadJRE:
; Call ElevateToAdmin
MessageBox MB_ICONINFORMATION "${PRODUCT_NAME} uses Java Runtime Environment ${JRE_VERSION}, it will now be downloaded and installed."
StrCpy $2 "$TEMP\jre-6u7-windows-i586-p.exe"
inetc::get /PROXY www-proxy.boeing.com:31060 /TIMEOUT=30000 ${JRE_URL} $2 /END
;InetLoad::load /POPUP "JRE downloading..." /TIMEOUT=30000 ${JRE_URL} $2 /END
;nsisdl::download /TIMEOUT=30000 ${JRE_URL} $2
Pop $R0 ;Get the return value
StrCmp $R0 "Download successful." +3
MessageBox MB_ICONSTOP "Download failed: $R0"
Abort
ExecWait $2
Delete $2

ReadRegStr $R1 HKLM "SOFTWARE\JavaSoft\Java Runtime Environment" "CurrentVersion"
ReadRegStr $R0 HKLM "SOFTWARE\JavaSoft\Java Runtime Environment\$R1" "JavaHome"
StrCpy $R0 "$R0\bin\${JAVAEXE}"
IfFileExists $R0 0 GoodLuck
Call CheckJREVersion
IfErrors GoodLuck JreFound

; 4) wishing you good luck
GoodLuck:
StrCpy $R0 "${JAVAEXE}"
; MessageBox MB_ICONSTOP "Cannot find appropriate Java Runtime Environment."
; Abort </code>

Thank you for any assistance you can provide.

[Takhir]

StrCmp $R0 OK +3

[Ivan Andreevich]

Privet

I am downloading a 150 MB file. Everything works amazingly well in Windows XP, but it fails miserably in Windows Vista.

My code:
RequestExecutionLevel admin
InetLoad::load /POPUP " " "http://url.com/file.exe" "$INSTDIR\file.exe"

Any ideas?

[Takhir]

Vista Home Premium with updates, Kaspersky Internet Security 2009, 69 MB file download from Apache 2.2

code:
Name "InetClient Test"

OutFile "inetc.exe"

RequestExecutionLevel admin



!include "MUI.nsh"

!insertmacro MUI_PAGE_WELCOME

!insertmacro MUI_PAGE_INSTFILES

!insertmacro MUI_LANGUAGE "English"



Section "Dummy Section" SecDummy



    SetDetailsView hide

    inetc::get /popup " " "http://localhost/css/ltrm2_wwefg_win.exe" "$EXEDIR\light_room.exe" /end

    Pop $0

    MessageBox MB_OK "Download Status: $0"



SectionEnd

works_for_me. NSIS 2.40 exe 1.5 MB download from sourceforge.net is OK too. May be this is your Vista security limitations?

[Ivan Andreevich]

I was confused as I was using InetLoad and you are supporting inetc here Can you add a note that inetc is a more up to date version than InetLoad on the InetLoad wiki? I wouldn't have used it in the first place.

I have made some custom modifications to the C code, and it seems that it's some of those that break under Vista for one reason or another. I tested the vanilla version, and there is no problem, so you can disregard my previous message altogether.

[xbarns]

Hi,

as i wrote above i cannot get it to work with a NSIS Unicode Build (2.38-1) any Ideas on this? I am building the inetc.exe with the "example_unicode.nsi" from the Zip.

Does anyone else get this to run?

Thanks.

[Takhir]

Last time I've built and included inetcu.dll to Wiki package in February 2008... Attached version was created from latest (Sept. 1, 2008) sources. Unfortunatelly on new comp I have not NSIS Unicode installed, so attached Unicode plug-in variant is not tested...

[xbarns]

Works like a charm, thanks a lot

[zxn]

Does plugin support FTP-over-HTTP proxy servers?

Thanks a lot

[Takhir]

Does plugin support FTP-over-HTTP proxy servers?

Not worked in my test (Connection Error). Plugin should use IE proxy settings by default, but I also tested manual proxy settings - not helps. Windows XP CLI ftp client not worked as well. Browsers are OK, so probably WinInet.dll has less ftp functionality then IE or Mozilla.

[redxii]

I tested with Windows 7 and IE8 w/ XP SP3 and at least inetc::get worked fine.

Just thought I'd report.

[gudy]

when used in the .onInit function, inetc prevents the main installer window from being shown in the forefront.

I guess that this is because you create a dialog, even when the /silent option is passed, and that dialog must become the forefront one (even when displayed as SW_HIDE), and then when the installer shows its dialog, it can't bring it to front.

Any way this could get fixed?

[Afrow UK]

Just found an interesting problem using this plugin on a machine. I am still doing tests but here's the situation:

Running the installer in the place of userinit.exe (meaning it runs before userinit.exe is executed and therefore before explorer.exe).

The plugin downloads the Adobe Flash Player ActiveX plugin for Internet Explorer. It gets to 100% and then the installer freezes. Soon after this the entire machine freezes, first being the task bar followed by the desktop and then any other programs running (for example, LogMeIn also stops functioning).

Hopefully it is this machine that is the problem, but either way do you see any possible reasons for this?

Edit: It was happening during silent install as well but I have only found it is the plugin by running in non silent mode - or rather I assume it is the plugin as it still shows the downloading progress bar at 100%.

Stu

[Takhir]

gudy: thanks, but this is very long story of attempts to keep installer foreground in such situations. BTW the same problem has place with few other plug-ins. I can test fixes if you have ideas. Might be good to have solution for both silent and not silent modes.
Afrow: I am not realy understand when plug-in was running. If we are talking about calling this dll from Windows service (i.e. from SESSION, not from Desktop) - I never tested ths mode. I only can say that task bar and desktop are Windows Explorer subsystems, they freezes when Explorer is (almost) died.

[Afrow UK]

It appears to be a problem with the machine so sorry about that!

Stu

[nachoesmith]

Hi there,

Do you have any experience with checking the hostname inside the CN field of a server certificate?

One of the checks that I need to have is that the server name inside the certificate ends in the correct domain. Of course, this would be in addition to the checks that wininet would do for you, which is that the name of the server connected to is the same as that in the CN field of the cert from the server, and that the cert is issued by a trusted authority.

I'm guessing that the easiest way to do this is to probably call InternetQueryOption just after InternetConnect, with the parameter INTERNET_OPTION_SECURITY_CERTIFICATE_STRUCT , which would return a INTERNET_CERTIFICATE_INFO struct. The lpszSubjectInfo member should contain the information I need, once I figure out how to tear it apart. What do you think?

I was thinking that the domain that I'd be checking for would be passed in as a parameter.

What would be the process for having this submitted back to you so that it could be included in the standard release?

[Takhir]

This is first request for server certificate fields verification, IMHO no sence to overload plug-in with seldom used features. But you can create your own version of plug-in with this feature and even add it to NSIS wiki

[spidercc]

Hi,

is there a way, or will there be a way, to start the download in async. mode.

Right now, i copy wget and start it async. with ExecDos,
but using InetLoad would look much better.

[Takhir]

Right now - no .

[redxii]

Is there an updated unicode build, you can probably include both call the unicode one 'inetcu.dll' or something.

[garygumdrops]

Has anyone else had any problems with McAfee Virus scanning whining about the Inetload DLL having a 'generic!bg.hpk' virus?
It's deleted my inetload.dll and broke my build but has been working for ages up until now. Perhaps McAfee has updated the virus definitions and only picked up on this today.

[MSG]

garygumdrops: There are many posts about such problems. Search before you post, please.

[stb]

Please report false positives: http://www.mcafee.com/us/threat_cent...spute_form.asp

Look at: http://nsis.sourceforge.net/NSIS_False_Positives

[morty3]

Hi all,

I have some troubles downloading JRE and JDK from Sun's homepage.

I simply use the following code:

code:


inetc::get  $0 "$TEMP\Setup.exe" /END

Pop $0 # return value = exit code, "OK" if OK

DetailPrint "Download result = $0"

where $0 contains the url.

Now this only works with the JRE online installer[1], trying to download JRE offline[2] or JDK offline[3] installer does the following:
The download finishes in just a couple of seconds (although the files aren't that small), exit code is "OK", but the download is obviously not complete.
If I add the /POPUP option, I get a Connection Error.

Can anybody reproduce this and think of an sulotion?

I really like the plugin, please kept up that good work!

Thanks in advance,
morty

Um, how do I add URL correctly?

[1] JRE online
[2] JRE offline

[3] JDK offline

[Takhir]

I tested following script with first of your URLs http://javadl.sun.com/webapps/downlo...BundleId=33787

code:
Name "InetClient GET Test"

OutFile "get.exe"



  !include "MUI.nsh"

  !define MUI_ICON "${NSISDIR}\Contrib\Graphics\Icons\modern-install-colorful.ico"

  !insertmacro MUI_PAGE_WELCOME

  !insertmacro MUI_PAGE_INSTFILES

  !insertmacro MUI_LANGUAGE "English"



Section "Dummy Section" SecDummy



    SetDetailsView hide



; single file, NSISdl-style embedded progress bar with specific cancel button text

    inetc::get /canceltext "interrupt!" "http://javadl.sun.com/webapps/download/AutoDL?BundleId=33787" "$EXEDIR\jre.exe" /end

    Pop $1



    MessageBox MB_OK "Download Status: $1"

SectionEnd





;--------------------------------

;Installer Functions



Function .onInit



FunctionEnd

and found 698kB file as a result. When started this exe displays JRE installation window (see attachment).
Please check /POPUP mandatory parameters in your script.