Opus support? {Implemented with a 3rd party plug-in by thinktink)

[thinktink]

Hooray for log files. Should probably do that more often.

Anyways, with the attached build 46 there's a 50/50 chance it might work depending on the true source of the error.

Same instructions as before.

[embryonic]

The file in D: is still not working yet, unfortunately.

After messing around for a bit, I guess the culprit is the Opus libraries that I am using. The example decoder provided in the zip file couldn't decode those files either, yet a copy of opusdec I have does it just fine.

Could you post the libraries you are using here? I would like to test it.

[Kaminari]

If your files are encoded with libopus 1.1 alpha/beta, it might lead to issues with the Winamp plugin (which is built around libopus 1.0). I did many tests myself with both versions and didn't encounter any problem, but who knows. If your files include surround channels, you should check that the option "Force stereo on multichannel audio" is disabled, otherwise the plugin won't play or will even crash.

[thinktink]

I think you're barking up the wrong tree. The errors in the log weren't being generated by the opus libraries, they originated from my code. With the new log posted I can only surmise that the way I'm converting from long to short filenames for use with the unicode-incompatible libraries is not compatible with whatever kind of drive your D: is on Win8. "Windows API" wise it shouldn't matter but obviously something's up.

[embryonic]

Wait, libopusfile does not support Unicode, and you are using short names instead?

I guess I know why.

code:
C:\Windows\system32>fsutil 8dot3name query c:

The volume state is: 0 (8dot3 name creation is enabled).

The registry state is: 2 (Per volume setting - the default).

Based on the above two settings, 8dot3 name creation is enabled on c:



C:\Windows\system32>fsutil 8dot3name query d:

The volume state is: 1 (8dot3 name creation is disabled).

The registry state is: 2 (Per volume setting - the default).

Based on the above two settings, 8dot3 name creation is disabled on d:

Is there any way to work around this?

[thinktink]

'Lemme go pound the pavement over at the hydrogen audio forums for a while...

In the meantime, the only "workaround" is to not store opus files on drives without 8dot3 filename support.

[EDIT/]
Note to myself:
http://www.hydrogenaudio.org/forums/...ic=101817&st=0

[embryonic]

Thanks. I really appreciate your help.

It seems that 8.3 name generation is disabled on all but the system volume on Windows 8 by default. All other NTFS partitions formatted with Windows 8 are showing as disabled.

[thinktink]

Update:

I've been able to replicate the issue by temporarily disabling system-wide 8dot3 file support on my WinXP32Home machine. What I can do about it I have no idea. This is all libopusfile's fault.

[thinktink]

k, after having a look at the libopusfile callback functions suggested over at the other forums I do believe I know what I need to do. However, I'm in the middle of a tight week at the moment so it may take some time to run up.

Please be patient...

[thinktink]

Solid progress, I am making it...

[thinktink]

Blammo...


...I think.

Version 1.2.16.48 attached.

[embryonic]

It's working now. Thank you very much.

[MrX_1980]

Hi, I have downloaded 3 times this file to "My Music" folder and if I double click on it, Winamp starts and crashing.
http://media.xiph.org/monty/demo/opu...oncut-1.1.opus

Streaming this file works.

winamp57_3437_beta_full_all.exe
BogProgOpus1_2_16_48Install.zip

Windows 8.1 and not Windows 8 like the log file say.

[Kaminari]

I had the same issue. Go to the plugin config window and make sure that the option "Force stereo on multichannel audio" is not enabled.

[thinktink]

The force stereo option only works for local file playback and the Transcoder functions. Not for online streams so I don't know how that can possibly effect streaming playback. Humdinger.

With the crashing, I need to know if it's crashing at the beginning of playback, the end of playback, in the middle of playback at a specific point, at a random point, or just if it's in the playlist or some other sequence of events?

Does it crash if you download it first and then play it back from a local drive?

[Kaminari]

In my case, this is what happens when Force Stereo is enabled:

o I download the file on my local drive (it's a multichannel test file btw).
o I open it with Winamp via double click.
o Playback starts, but it sounds distorded and accelerated.
o If I start the playback a second time (without closing Winamp), the app crashes immediately.

For info, Chrome 28 and Firefox 22 natively play the file without any issue.

[Edit] Link to the demo presentation (see section Surround masking):
http://people.xiph.org/~xiphmont/demo/opus/demo3.shtml

[thinktink]

I just did some preliminary tests and I found that it seems the libopusfile api function "op_read_stereo" (used when forcing stereo instead of "op_read") doesn't like it when it is called on OggOpusFile handles created using "op_open_callbacks" (instead of "op_open_file"), which is what I was forced to use to enable Unicode named files/paths on Windows filesystems without 8dot3 file name support.

This looks like it may actually be libopusfile's fault. I'll have to do more testing to confirm my suspicions but I'm really tired right now and I need sleep. Just came off a long day.

[MrX_1980]

Originally Posted by Kaminari

I had the same issue. Go to the plugin config window and make sure that the option "Force stereo on multichannel audio" is not enabled.

Thanks, now the local file not crashing directly after the Winamp start (always at the beginning of playback).

[thinktink]

Version 1.2.17.52 attached. See if it stops crashing Winamp when you have "Force Stereo on multichannel audio" re-enabled please. It stopped on my machine, just want to confirm it stops for you.

[MrX_1980]

Hi, the local playback is working now, but if I stop this stream Winamp crashes always (force Stereo on or off).
http://icecast.timlradio.co.uk:80/a064.opus

[thinktink]

I just replicated your issue. However, I'm in the middle of a funeral and I can't troubleshoot the issue 'till afterwards.

I swear...

...ever since I put in Unicode support for Unicode files on filesystems without 8dot3 name support everything has gotten demonstrably worse all around. Driving me up the wall...

[MrX_1980]

No problem. With the version before and Force Stereo off I can use it and can wait.
Thanks so far.

[thinktink]

Here you go, this should hold you down for a while...





Attached.

[thinktink]

Is everything working now?

[Kaminari]

Xiph's media server was down for a couple of days, but it's back now. I just tested your latest build with the multichannel demos and it all looks a-ok to me. Surround is successfully forced to stereo without crashing, and Unicode still works

Thank you for your great support.

[kzuse]

Same here, everything fine with the latest build!

Thank you!

[MrX_1980]

It is not crashing anymore.
Thank you thinktink.

[thinktink]

Originally Posted by My E-Mail Inbox

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm pleased to announce the availability of opusfile v0.4.

The opusfile and opusurl libraries provide a high-level API for
decoding and seeking within .opus files on disk or over http(s).

* https://ftp.mozilla.org/pub/mozilla....ile-0.4.tar.gz
* https://ftp.mozilla.org/pub/mozilla....usfile-0.4.zip

* http://downloads.xiph.org/releases/o...ile-0.4.tar.gz
* http://downloads.xiph.org/releases/o...usfile-0.4.zip

*
https://ftp.mozilla.org/pub/mozilla....-0.4-win32.zip

Changes since v0.3:

- - New API to parse album art tags.
- - Visual Studio project file fixes.
- - Include Visual Studio projects in source package.
- - Minor unicode fixes.

Changes since v0.2:

- - Fix a buffer overflow downmixing multichannel files.
- - UTF-8 filename support on Windows.
- - HTTP(S) url support on Windows.
- - Support Windows system certificate store for HTTPS.
- - New project files for MS Visual Studio.
- - New gain control API with op_set_gain_offset() and op_get_track_gain().
- - Documentation and build improvements.
- - HTTP(S) support split into a separate opusurl library.
- - Implement soft-clip for paths where libopus doesn't.
- - opusfile_example now outputs WAV.
- - Fix http basic auth.
- - Fix 255 packet-per-page assert.

We recommend upgrading for all current users. If you're not a current
user, please give it a try!

Checksums:

4248927f2c4e316ea5b84fb02bd100bfec8fa4624a6910d77f0af7f0c6cb8baa
opusfile-0.3.tar.gz
9836ea11706c44f36de92c4c9b1248e03a4c521e7fb2cff18a0cb4f8b0e79140
opusfile-0.4.tar.gz
f187906b1b35f7f0d7de6a759b4aab512a9279d23adb35d8009e7e33bd6a922a
opusfile-0.4.zip
ae23da5963295c6aa13c97becf50ae013e2317706f0e2a9472f2384aa70aaa43
opusfile-0.4-win32.zip

We didn't announce v0.3 separately because the Visual Studio project
files were one of the major new features...but we forgot to include
them in the source package.

Thanks to everyone who contributed!

-r
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSE+v3AAoJEEcAD3uxRB3vJMoH/1ZciZWEdWPTevoqo/zfHyPu
FDrohLby9tH0LgdbIFDtHwxnfbyVFRkwYd9b1XPwDgecdCWSVImOPeF7H59umIB/
ZrFL+EYZvhsSj2dTihDlPHkdORz1dRW3cKWbuc+xL+op4XJ/+TrzCdhsKKSKQPU6
dyxZquLcaZ41QIpyWjJ3e5mGDyhsfvAgRB6XKWfhk7fcxD1hCbcXqLkMZAwUL35q
M1b6VP1R8NfA50Gs1wYX843Zj3ZH0mGg02gEkXePLeQhBGtWw455jLsMBg9+7BD0
+OCAZeZVMVq/l7PqaquIb3AhK03DP1Rm7lNi++3G2A2/eKgjgndnpXRd33Ij9aU=
=jUQS
-----END PGP SIGNATURE-----

On it like a duck on a June Bug.

[gottkaiser]

Big thanks for the continuous development!
Keep up the the great work.

[Omega X]

Any chance for average bitrate display?

[thinktink]

Originally Posted by Omega X

Any chance for average bitrate display?

Active bitrate display updates were disabled due to the following issues:
http://forums.winamp.com/showthread....27#post2917927

http://forums.winamp.com/showthread....72#post2918272

Updating the bitrate requires calling SetInfo(...), which causes UI errors for some reason from my plugin. The other plugins are able to without the problems but not mine and I do not know why.

[thinktink]

After dropping a debug build of X-Fade into Winamp with temporary code to hook the SetInfo(...) function, I discovered that the other plugins are passing -1 to parameters that it doesn't want to update. My plugin was (before I disabled it) passing all of the parameters, thinking that since it was the same information as before that it wouldn't change anything. Apparently, that is not the case.

The current development code stage of the plugin is currently being worked on to integrate the new libopusurl APIs so I don't know when I'll be able to outchuck it. I'll will post the updated version as soon as possible. At the moment, I'm stymied trying to get the Punicode functions to work correctly (which is for support for internationalized domain names) and it's driving me up the wall. I have yet to find C++ code that outputs a proper Punicode string that matches what all the other examples that I've found online purport to output for DNS names.

[drsox]

Using this plugin to listen to streamed opus from icecast servers.. working great.
One thing I want to comment is that the plugin doesn't seem to be invoked unless the extension is .opus.. for example a stream on http://server.radiostation.com:8000/opus doesn't play but modifying the address to be http://server.radiostation.com:8000/opus?.opus tricks it into working.

[thinktink]

Originally Posted by drsox

Using this plugin to listen to streamed opus from icecast servers.. working great.
One thing I want to comment is that the plugin doesn't seem to be invoked unless the extension is .opus.. for example a stream on http://server.radiostation.com:8000/opus doesn't play but modifying the address to be http://server.radiostation.com:8000/opus?.opus tricks it into working.

You can force it by changing the protocol field of the URL from http:// to opus:// without having to add anything to the end.

[thinktink]

Release (non-beta) version 1.3.19.61 attached.

Updates:

• Re-added support for real-time bitrate display without causing UI glitches on classic skins.
• Added true IRI support (IDNA+Unicode resources) for online streams and files.
• Added support for libopusurl APIs. However, since the current beta compile of libopusurl does not include the additions to the API after the compiled release (that I had a small part in) the plugin automatically falls back to it's own stream thread handler. A compiled version of libopusurl that includes the additions will be picked up and used without needing to release a new version of the plugin.

Installer now includes the following support libraries from the opusfile-0.4-win32 package:

• libeay32.dll
• ssleay32.dll
• libopusurl-0.dll

The old support files are also updated with new files from the aforementioned package.

[noart47]

registered to say thanks thinktink...


Thanks thinktink!

[Kigen]

Hi thinktink,

I've been trying to use BogProgOpus. However, anytime I tune-in to my stream it says "waiting for data" then disconnects.

http://radio.kigen.co:8000/xrm.opus

Any ideas why it might be doing that? I've tested it with Mozilla Firefox, foobar2000, VLC, and other players and they work. The encoding is done by Liquidsoap.

Thanks.

[thinktink]

I popped your URL into Winamp and played it and it popped right up.



Which OS you on?

[Kigen]

Windows 8.1 Pro

[thinktink]

I'll see if I can replicate the issue on Windows 7 Pro.